This repository was archived by the owner on Dec 9, 2021. It is now read-only.
Replace message dialogs with inline messages (KMessageWidget)#78
Open
pgalves wants to merge 9 commits intokeepassx:masterfrom
Open
Replace message dialogs with inline messages (KMessageWidget)#78pgalves wants to merge 9 commits intokeepassx:masterfrom
pgalves wants to merge 9 commits intokeepassx:masterfrom
Conversation
(https://github.com/torvalds/subsurface, commit: 82a946152b7f1da177344937acbc9d3cb5b0ccbf). Added MessageWidget class.
DatabaseOpenWidget.
inline MessageWidget in ChangeMasterKeyWidget.
EditWidget and in UnlockDatabaseWidget. Add missing method to show Information Message.
Chnage to one method to set MessageWidget text passing type as parameter. Only messages with questions requiring user input reamin using MessageBox dialog. Use signal/slots to set message in MessageWidget and hide message, signal/slots only used when required.Maybe need to change all calls to signals/slots in the future.
|
Looking Great. Would be great to be able to link through: "Can't delete icon. Still used by 1 item(s). Go to this item " |
Author
|
@tvld Thanks. I agree, that message could be improved to show where the icon is still used. But for now I just wanted to keep it simple and use the current KepassX warning strings. |
daniellandau
pushed a commit
to daniellandau/keepassx
that referenced
this pull request
Sep 24, 2017
…-messages KeePassX PR Migration: keepassx#78 Inline Messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the message dialogs not requiring user interaction (passive information) with an inline message widget. The code used for the widget is borrowed from subsurface. This widget is similar to KMessageWidget from KDE libraries but has the KDE bits removed.
Messages can be displayed over the Tab Bar for generic messages or inside the tab for messages related with tab content.
Only tested on Linux.
Some screenshots:
