Skip to content
This repository was archived by the owner on Dec 9, 2021. It is now read-only.

Min on close#100

Open
cbrunet wants to merge 2 commits intokeepassx:masterfrom
cbrunet:minOnClose
Open

Min on close#100
cbrunet wants to merge 2 commits intokeepassx:masterfrom
cbrunet:minOnClose

Conversation

@cbrunet
Copy link
Copy Markdown
Contributor

@cbrunet cbrunet commented May 15, 2015

I like to keep my KeePass database open. However, I often hit the window close button when I just want to hide the application window. With this option, hitting the close button simply minimize the window instead of closing it. To quit the application, you need to use the menu, or the keyboard shortcut.

@ryanoasis
Copy link
Copy Markdown

👍 times a million!

@alerque
Copy link
Copy Markdown

alerque commented Jun 26, 2015

An option to minimize on copy events would be great (to go along with the auto-type behavior that already exists) but having a program ignore the close button and minimize instead is a big no-no in my book. That's just the sort of unpredictable behavior I don't want from my desktop applications.

@ryanoasis
Copy link
Copy Markdown

@alerque I see what you mean and that makes sense but I don't see why it can't be an option (not the default). I think I am used to programs that minimize to a taskbar where close closes the window but does not close the actual application. In this sense to me that is not unpredictable behaviour especially if the extra option is selected by the user to function that way.

@alerque
Copy link
Copy Markdown

alerque commented Jun 26, 2015

@ryanoasis I work on multiple platforms. Not all platforms even allow that action override. It would be unpredictable in that the same program would operate fundamentally differently of different platforms and in that a user that had not familiarized themselves with the options wouldn't know what to expect when they hit the close button. Also, on order to support the option you would have to have separate code bases for different operating systems and and disable the option when it wasn't available. That would add clutter to the code in addition to the clutter in the options.

Of course you can do whatever you like in your own fork but as far as getting this contributed upstream goes I would prefer to see (and recommend trying) just the minimize-on-copy option as that is much more generally useful, not something people can work around through their window managers anyway.

@cbrunet
Copy link
Copy Markdown
Contributor Author

cbrunet commented Jun 26, 2015

The option to minimize on copy already is there.

Which platform is causing problem? This works without problems on Linux, and it should work on Windows as well. And as already mentioned, this is an option. Therefore, if you don't want it, just do not check that option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants