Fix missing tolerations keyword in keda chart#481
Merged
wozniakjan merged 1 commit intoJun 2, 2026
Conversation
* Fix missing tolerations keyword Signed-off-by: Mikolaj Mackowiak <[email protected]> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> --------- Signed-off-by: Mikolaj Mackowiak <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Co-authored-by: Copilot Autofix powered by AI <[email protected]> (cherry picked from commit 102f5f2)
There was a problem hiding this comment.
Pull request overview
This PR fixes Helm-rendered Deployment manifests in the keda chart when users set the global .Values.tolerations value, ensuring the emitted YAML includes the required tolerations: key (and correcting an indentation issue in the operator deployment template). This restores valid tolerations rendering for operator, metrics-server, and webhooks deployments.
Changes:
- Add missing
tolerations:key when falling back to global.Values.tolerationsin webhooks and metrics-server Deployment templates. - Fix operator Deployment template to correctly render global
.Values.tolerationswithtolerations:and propernindent. - Minor template whitespace-trim consistency improvement noted in webhooks template.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| keda/templates/webhooks/deployment.yaml | Adds tolerations: key for global tolerations fallback in the webhooks Deployment. |
| keda/templates/metrics-server/deployment.yaml | Adds tolerations: key for global tolerations fallback in the metrics-server Deployment. |
| keda/templates/manager/deployment.yaml | Fixes global tolerations fallback to emit tolerations: and correct indentation in the operator Deployment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wozniakjan
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tolerations:key to the global.Values.tolerationsfallback branch in the operator, metrics-server, and webhooks deployment templates (and fixes a straynindentin the operator template)..Values.tolerationsrendered the toleration list without thetolerations:key, so it was invalid/ignored.helm lintandhelm template(all three deployments now emit the block).