Merged
Conversation
Signed-off-by: ithesadson <[email protected]>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: ithesadson <[email protected]>
Signed-off-by: ithesadson <[email protected]>
6 tasks
tomkerkhove
reviewed
Mar 20, 2023
Signed-off-by: ithesadson <[email protected]>
tomkerkhove
reviewed
Mar 20, 2023
Member
tomkerkhove
left a comment
tomkerkhove
left a comment
There was a problem hiding this comment.
LGTM, but waiting for feature to be merged. However, can you move this file to 2.11 please? 2.10 was already shipped
Signed-off-by: ithesadson <[email protected]>
Contributor
Author
|
Contributor
Author
|
I accidentally closed the pull request and then reopened it, sorry about that. |
zroubalik
reviewed
Mar 21, 2023
tomkerkhove
approved these changes
Mar 21, 2023
Signed-off-by: ithesadson <[email protected]>
zroubalik
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Releates to:
kedacore/keda#4234
kedacore/keda#4355