e2e: pin redis to v0.28.0#7768
Merged
Merged
Conversation
Signed-off-by: Jan Wozniak <[email protected]>
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
rickbrouwer
approved these changes
May 25, 2026
Merged
3 tasks
Member
Author
|
/run-e2e redis passed tests: 12failed tests: 0 |
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the CloudPirates Redis Helm chart used by Redis scaler e2e helpers to a known-good version to prevent test breakage when upstream releases publish a broken “latest”.
Changes:
- Add a package-level constant for the Redis chart version (
0.28.0). - Pass
--version 0.28.0to Helm for standalone, sentinel, and cluster Redis installs in e2e tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Jan Wozniak <[email protected]>
shcherbak
pushed a commit
to shcherbak/keda
that referenced
this pull request
Jun 3, 2026
* e2e: pin redis to v0.28.0 Signed-off-by: Jan Wozniak <[email protected]> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> --------- Signed-off-by: Jan Wozniak <[email protected]> Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Yurii Shcherbak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see also: CloudPirates-io/helm-charts#1336
the redis chart 0.29.x are broken, since our e2e tests don't pin the chart version and always install latest, they started to fail last week. Proposing to pin the chart to latest know installable version of the chart.