fix: emit active metric for resource scalers by puneetdixit200 · Pull Request #7755 · kedacore/keda

puneetdixit200 · 2026-05-21T17:15:08Z

This records keda_scaler_active for resource metrics before skipping the CPU/memory metric specs that KEDA does not query directly. The existing behavior for resource metric values/errors stays unchanged, but the active metric is initialized so dashboards can resolve labels for ScaledObjects that only use CPU or memory triggers.

Tests:

GOMODCACHE="$PWD/.gomodcache" GOCACHE="$PWD/.gocache" go test ./pkg/scaling -run TestGetScaledObjectStateRecordsResourceScalerActiveMetric -count=2
GOMODCACHE="$PWD/.gomodcache" GOCACHE="$PWD/.gocache" go test ./pkg/scaling -count=1
GOMODCACHE="$PWD/.gomodcache" GOCACHE="$PWD/.gocache" go test ./pkg/metricscollector -count=1
git diff --check

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Ensure make generate-scalers-schema has been run to update any outdated generated files
Changelog has been updated and is aligned with the changelog requirements
A PR is opened to update the Helm chart
A PR is opened to update the documentation if applicable
Commits are signed with Developer Certificate of Origin

Documentation, Helm chart, scaler schema, and new-scaler governance updates are not applicable here because this only initializes an existing metric and does not change manifests, scaler schemas, or public configuration.

Signed-off-by: Puneet Dixit <[email protected]>

github-actions · 2026-05-21T17:15:19Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

snyk-io · 2026-05-21T17:15:32Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Signed-off-by: Puneet Dixit <[email protected]>

Use context.Background in the resource scaler active metric regression test instead of context.TODO. Signed-off-by: Puneet Dixit <[email protected]>

JorTurFer · 2026-05-25T11:39:12Z

Thanks for the great improvement! I think that this makes sense to be included as part of e2e test

By adding a test also there, we can ensure that the metric will be always rightly generated

Copilot

Pull request overview

This PR fixes missing initialization of the keda_scaler_active Prometheus metric for CPU/memory (resource) triggers by recording activity metrics for resource and containerResource metric specs that KEDA otherwise skips querying directly. This improves Grafana dashboard label discovery for ScaledObjects that only use CPU/memory triggers.

Changes:

Record keda_scaler_active for Resource / ContainerResource metric specs before continuing past non-external metric specs.
Add a unit test that asserts keda_scaler_active is emitted with the expected labels for a CPU resource trigger.
Add a changelog entry for the fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
pkg/scaling/scale_handler.go	Emit `keda_scaler_active` for resource/containerResource metric specs that were previously skipped.
pkg/scaling/scale_handler_test.go	Add regression test to ensure the active metric is emitted for resource scalers.
CHANGELOG.md	Document the bugfix for missing `keda_scaler_active` on CPU/memory triggers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Puneet Dixit <[email protected]>

puneetdixit200 · 2026-05-25T14:15:05Z

Added the requested Prometheus and OpenTelemetry sequential coverage in 6f2ee46. Local checks passed: go test ./pkg/scaling -count=1, and go test -tags e2e ./tests/sequential/prometheus_metrics ./tests/sequential/opentelemetry_metrics -run "^$" -count=0.

zroubalik · 2026-05-26T07:38:10Z

/run-e2e sequential
Update: You can check the progress here

puneetdixit200 · 2026-05-26T08:16:45Z

Thanks for running the sequential e2e. I checked the failing run/artifact and it looks like this failed in shared setup before the new sequential metric tests ran: TestVerifyKEDA timed out waiting for keda-admission to reach 1 replica after 3 minutes, while keda-webhooks.log shows the admission webhook process started at 2026-05-26T08:04:02Z immediately after that wait window. The operator and metrics server logs otherwise came up normally.

Could you rerun /run-e2e sequential when you have a chance?

Signed-off-by: Rick Brouwer <[email protected]>

rickbrouwer · 2026-05-26T08:18:37Z

/run-e2e sequential
Update: You can check the progress here

passed tests: 5

Execution of tests/sequential/disruption/disruption_test.go, has passed after "one" attempts
Execution of tests/sequential/prometheus_metrics/prometheus_metrics_test.go, has passed after "one" attempts
Execution of tests/sequential/datadog_dca/datadog_dca_test.go, has passed after "one" attempts
Execution of tests/sequential/broken_scaledobject_tolerancy/broken_scaledobject_tolerancy_test.go, has passed after "one" attempts
Execution of tests/sequential/opentelemetry_metrics/opentelemetry_metrics_test.go, has passed after "one" attempts

failed tests: 0

…-scaler-active Signed-off-by: Deepak kudi <[email protected]> # Conflicts: # CHANGELOG.md

puneetdixit200 · 2026-05-28T01:14:08Z

Merged current main into this branch to clear the dirty state. Current head is 3492f0bd.

Local verification before push:

git diff --check
go test ./pkg/scaling -count=1 (ok github.com/kedacore/keda/v2/pkg/scaling 2.960s)

Fresh GitHub checks are queued/running now; DCO is already green.

puneetdixit200 · 2026-05-28T01:14:30Z

Merged current main into this branch to clear the conflict. The only manual conflict resolution was keeping the existing CHANGELOG.md General fix entry for #4945 in the current Unreleased Fixes list.

Local verification:

git diff --check upstream/main...HEAD
go test ./pkg/scaling -count=1
go test -tags e2e ./tests/sequential/prometheus_metrics ./tests/sequential/opentelemetry_metrics -run "^$" -count=0

GitHub checks are running on the new head 3492f0bd.

rickbrouwer · 2026-06-01T07:00:06Z

/run-e2e sequential
Update: You can check the progress here

passed tests: 5

Execution of tests/sequential/opentelemetry_metrics/opentelemetry_metrics_test.go, has passed after "one" attempts
Execution of tests/sequential/disruption/disruption_test.go, has passed after "one" attempts
Execution of tests/sequential/prometheus_metrics/prometheus_metrics_test.go, has passed after "one" attempts
Execution of tests/sequential/datadog_dca/datadog_dca_test.go, has passed after "one" attempts
Execution of tests/sequential/broken_scaledobject_tolerancy/broken_scaledobject_tolerancy_test.go, has passed after "one" attempts

failed tests: 0

…ration (#7808) #7755 added TestGetScaledObjectStateRecordsResourceScalerActiveMetric and TestGetScaledObjectStateSkipsResourceScalerActiveMetricWithModifiers using record.NewFakeRecorder. In the meantime #7781 migrated this file to the events recorder and dropped the k8s.io/client-go/tools/record import, so the merged result fails to compile with "undefined: record", breaking the unit-test build and Static Checks on main. Use events.NewFakeRecorder, matching the rest of the file and the events.EventRecorder type of the Recorder/recorder fields. Signed-off-by: Jan Wozniak <[email protected]>

Signed-off-by: Puneet Dixit <[email protected]> Signed-off-by: Rick Brouwer <[email protected]> Co-authored-by: Puneet Dixit <[email protected]> Co-authored-by: Rick Brouwer <[email protected]> Co-authored-by: Deepak kudi <[email protected]> Signed-off-by: Yurii Shcherbak <[email protected]>

…ration (kedacore#7808) kedacore#7755 added TestGetScaledObjectStateRecordsResourceScalerActiveMetric and TestGetScaledObjectStateSkipsResourceScalerActiveMetricWithModifiers using record.NewFakeRecorder. In the meantime kedacore#7781 migrated this file to the events recorder and dropped the k8s.io/client-go/tools/record import, so the merged result fails to compile with "undefined: record", breaking the unit-test build and Static Checks on main. Use events.NewFakeRecorder, matching the rest of the file and the events.EventRecorder type of the Recorder/recorder fields. Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Yurii Shcherbak <[email protected]>

fix: emit active metric for resource scalers

f4f2c1a

Signed-off-by: Puneet Dixit <[email protected]>

puneetdixit200 requested a review from a team as a code owner May 21, 2026 17:15

keda-automation requested a review from a team May 21, 2026 17:15

semgrep-code-kedacore Bot reviewed May 21, 2026

View reviewed changes

Comment thread pkg/scaling/scale_handler_test.go Outdated

puneetdixit200 added 2 commits May 22, 2026 12:03

test: fix scale handler import grouping

503ce15

Signed-off-by: Puneet Dixit <[email protected]>

test: use explicit context in scaler metric test

cc14306

Use context.Background in the resource scaler active metric regression test instead of context.TODO. Signed-off-by: Puneet Dixit <[email protected]>

JorTurFer requested a review from Copilot May 25, 2026 11:37

Copilot started reviewing on behalf of JorTurFer May 25, 2026 11:37 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

Comment thread pkg/scaling/scale_handler.go

fix: respect modifiers for resource scaler active metrics

6f2ee46

Signed-off-by: Puneet Dixit <[email protected]>

zroubalik approved these changes May 26, 2026

View reviewed changes

Merge branch 'main' into fix/4945-initialize-scaler-active

8e3950f

Signed-off-by: Rick Brouwer <[email protected]>

keda-automation requested a review from a team May 26, 2026 08:18

zroubalik added the Awaiting/2nd-approval This PR needs one more approval review label May 26, 2026

Merge remote-tracking branch 'upstream/main' into fix/4945-initialize…

3492f0b

…-scaler-active Signed-off-by: Deepak kudi <[email protected]> # Conflicts: # CHANGELOG.md

rickbrouwer added waiting-for-e2e and removed Awaiting/2nd-approval This PR needs one more approval review labels Jun 1, 2026

rickbrouwer approved these changes Jun 1, 2026

View reviewed changes

rickbrouwer enabled auto-merge (squash) June 1, 2026 07:01

rickbrouwer merged commit 92bca15 into kedacore:main Jun 1, 2026
25 checks passed

wozniakjan mentioned this pull request Jun 1, 2026

fix(test): unbreak scale_handler_test build after events recorder migration #7808

Merged

Uh oh!

Conversation

puneetdixit200 commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

snyk-io Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

Uh oh!

JorTurFer commented May 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

puneetdixit200 commented May 25, 2026

Uh oh!

zroubalik commented May 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puneetdixit200 commented May 26, 2026

Uh oh!

rickbrouwer commented May 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puneetdixit200 commented May 28, 2026

Uh oh!

puneetdixit200 commented May 28, 2026

Uh oh!

rickbrouwer commented Jun 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

puneetdixit200 commented May 21, 2026 •

edited

Loading

snyk-io Bot commented May 21, 2026 •

edited

Loading

zroubalik commented May 26, 2026 •

edited by github-actions Bot

Loading

rickbrouwer commented May 26, 2026 •

edited by github-actions Bot

Loading

rickbrouwer commented Jun 1, 2026 •

edited by github-actions Bot

Loading