Skip to content

fix(azure-event-hub): Fix division by 0 for threshold value in azure eventhub scaler#7733

Merged
wozniakjan merged 3 commits into
kedacore:mainfrom
dttung2905:fix-div-by-zero-azure-event-hub
May 19, 2026
Merged

fix(azure-event-hub): Fix division by 0 for threshold value in azure eventhub scaler#7733
wozniakjan merged 3 commits into
kedacore:mainfrom
dttung2905:fix-div-by-zero-azure-event-hub

Conversation

@dttung2905

Copy link
Copy Markdown
Contributor

I'm adding a validation step to guard against having threshold to be set at 0, resulting in division by zero

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added (if applicable)
  • Ensure make generate-scalers-schema has been run to update any outdated generated files
  • Changelog has been updated and is aligned with our changelog requirements, only when the change impacts end users
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #7732

@dttung2905 dttung2905 requested a review from a team as a code owner May 12, 2026 20:08
@github-actions

Copy link
Copy Markdown

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

@keda-automation keda-automation requested a review from a team May 12, 2026 20:08
@snyk-io

snyk-io Bot commented May 12, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Signed-off-by: dttung2905 <[email protected]>
Comment thread CHANGELOG.md Outdated
@rickbrouwer rickbrouwer added waiting-author-response All PR's or Issues where we are waiting for a response from the author required:keda-v2.20 This is absolutely mandatory to bring along labels May 13, 2026
Co-authored-by: Rick Brouwer <[email protected]>
Signed-off-by: Dao Thanh Tung <[email protected]>
@keda-automation keda-automation requested a review from a team May 13, 2026 20:25
@dttung2905 dttung2905 requested a review from rickbrouwer May 13, 2026 20:26
@rickbrouwer

rickbrouwer commented May 14, 2026

Copy link
Copy Markdown
Member

/run-e2e event_hub*
Update: You can check the progress here

@rickbrouwer rickbrouwer removed the waiting-author-response All PR's or Issues where we are waiting for a response from the author label May 14, 2026

@rickbrouwer rickbrouwer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rickbrouwer rickbrouwer added the Awaiting/2nd-approval This PR needs one more approval review label May 14, 2026
@wozniakjan wozniakjan merged commit d225068 into kedacore:main May 19, 2026
25 checks passed
@rickbrouwer rickbrouwer removed the Awaiting/2nd-approval This PR needs one more approval review label May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

required:keda-v2.20 This is absolutely mandatory to bring along

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure Event Hub scaler: panic on unprocessedEventThreshold: 0 (integer division by zero)

3 participants