fix(influxdb): make authToken optional for unauthenticated instances#7678
Merged
rickbrouwer merged 1 commit intoApr 26, 2026
Merged
Conversation
The docs mark authToken as Optional, but Validate() rejected empty tokens unconditionally. InfluxDB 3 Core (OSS) runs without auth by default, and the struct already tags authToken as optional, so the hard-required check was inconsistent. Remove the check and update the test case that asserted empty-token was an error. Fixes kedacore#7616 Signed-off-by: Ali <[email protected]>
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Member
|
/run-e2e influxdb |
rickbrouwer
approved these changes
Apr 25, 2026
rickbrouwer
added
the
Awaiting/2nd-approval
JorTurFer
approved these changes
Apr 26, 2026
rickbrouwer
removed
the
Awaiting/2nd-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The InfluxDB scaler's
Validate()rejects an emptyauthTokeneven though the documentation marks it as optional, and the struct already tags it asoptional. This breaks use against InfluxDB 3 Core (OSS), which runs without auth by default.Drop the unconditional
authToken is requiredcheck and update the matching test case (#8) so empty tokens are accepted for unauthenticated instances.Checklist
make generate-scalers-schemahas been run to update any outdated generated filesFixes #7616