fix(nats-jetstream): return error when configured consumer is missing#7668
Merged
rickbrouwer merged 1 commit intoApr 26, 2026
Merged
Conversation
Signed-off-by: Rob Blackman <[email protected]>
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Member
|
/run-e2e jetstream |
rickbrouwer
added
the
Awaiting/2nd-approval
JorTurFer
approved these changes
Apr 26, 2026
Member
|
Thanks a lot! |
rickbrouwer
removed
the
Awaiting/2nd-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the NATS JetStream scaler where a ScaledObject referencing a consumer that does not exist in the target stream would cause the workload to scale up to
maxReplicaCount.Root cause
getMaxMsgLag()iterates the stream's consumers looking for the configured one. If it isn't found, the function previously fell back to returnings.stream.State.LastSequence- the stream's last published sequencenumber. On any non-trivial stream this value is very large, exceeds any reasonable
lagThreshold, and the HPA scales the workload out to its maximum.Fix
getMaxMsgLag()now returns(int64, error)and surfaces an error when the configured consumer is missing, instead of returning the stream's last sequence.GetMetricsAndActivitypropagates that error so user-configuredfallbackbehaviour can take over.Behaviour change
Before: scaler silently reported a large metric and scaled to max replicas.
After: scaler returns an error; the ScaledObject's
fallbackcan engage, or the metric becomes unavailable until the consumer is created.Checklist
Fixes #7657