rfac: handle paused scaling directly in reconciler#7664
Merged
Conversation
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Member
Author
|
/run-e2e internal |
Signed-off-by: Rick Brouwer <[email protected]>
Member
Author
|
/run-e2e internal |
wozniakjan
approved these changes
Apr 21, 2026
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
added
the
Awaiting/2nd-approval
Member
Author
|
/run-e2e internal |
3 tasks
rickbrouwer
added
the
required:keda-v2.20
JorTurFer
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ScaledObject reconciler now handles the full pause lifecycle: stop scale loop, delete HPA, and scale the target directly via the scale subresource instead of recreating an HPA with min=max=N. This applies consistently to both
pausedandpaused-replicasannotations.Also aligned the ScaledJob pause flow with the same status-first pattern and idempotent scale loop stopping.
Added e2e tests for HPA absence during pause, annotation value changes and annotation switching while paused.
Checklist
make generate-scalers-schemahas been run to update any outdated generated filesFixes #7663