fix(metrics-api): use correct label selector in getEndpointsUrlsFromServiceURL#7642
Merged
Merged
Conversation
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
proudier
force-pushed
the
metrics-api-fix
branch
from
5be91e3 to
f2ba188
Compare
proudier
changed the title
…erviceURL Signed-off-by: Pierre Roudier <[email protected]>
proudier
force-pushed
the
metrics-api-fix
branch
from
f2ba188 to
100f5bc
Compare
Member
|
/run-e2e metrics_api |
1 task
rickbrouwer
added
the
Awaiting/2nd-approval
wozniakjan
approved these changes
Apr 11, 2026
rickbrouwer
removed
the
Awaiting/2nd-approval
Abhicodeitout
pushed a commit
to Abhicodeitout/keda
that referenced
this pull request
Apr 13, 2026
…erviceURL (kedacore#7642) Signed-off-by: Pierre Roudier <[email protected]> Signed-off-by: Abhishek Kumar Kushwaha <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue described in #7641
Root cause of the issue
labels.NewSelector()creates an empty selector matching everything, andMatches()is read-only — its return value was discarded. This caused KEDA to list allEndpointSlicesin the namespace instead of filtering bykubernetes.io/service-name.Content of this PR
EndpointSlicesand asserts only the target service's endpoints are returned.labels.SelectorFromSet()which correctly constrains the selector.Checklist
make generate-scalers-schemahas been run to update any outdated generated filesFixes #7641