✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

• Add an entry in our changelog in alphabetical order and link related issue
• Update the documentation, if needed
• Add unit & e2e tests for your changes
• GitHub checks are passing
• Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

/run-e2e forgejo
Update: You can check the progress here

/run-e2e forgejo
Update: You can check the progress here

Shouldn't we make this configurable? The same way activity is handled in other scalers?

@zroubalik Do you mean an ActivationValue? If so, do you want me to add that directly to this PR, or do you want to keep the 'fix' and 'feature' separate in terms of scoping?

Shouldn't we make this configurable? The same way activity is handled in other scalers?

@zroubalik Do you mean an ActivationValue? If so, do you want me to add that directly to this PR, or do you want to keep the 'fix' and 'feature' separate in terms of scoping?

I think it makes sense to do it in a single PR.

My other concern is actually a question why this hasn't been implemented in the scaler from the beginning? Does forgejo actually supports this? I don't know, just thinking out loud.

I think it makes sense to do it in a single PR.

Yes, me too, I like to keep things separate.

My other concern is actually a question why this hasn't been implemented in the scaler from the beginning? Does forgejo actually supports this? I don't know, just thinking out loud.

Good question why we missed this.
As far as I'm concerned, we can do 3 things:

1. I add the activation value in a separate PR.
2. I create a first-good-issue (although that would likely be picked up by an agent, but oh well)
3. We wait for a request from the community indicating that they are missing something.

3. a request from the community indicating that they are missing something.

I'd go with this approach personally.

/run-e2e forgejo
Update: You can check the progress here

I'd go with this approach personally.

Then we continue with this PR.