Handle NaN result from Prometheus#7522
Merged
rickbrouwer merged 6 commits intoMar 31, 2026
Merged
Conversation
Signed-off-by: Andrew Hall <[email protected]>
Signed-off-by: Andrew Hall <[email protected]>
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Andrew Hall <[email protected]>
Signed-off-by: Andrew Hall <[email protected]>
Member
|
/run-e2e prometheus |
rickbrouwer
requested changes
Mar 6, 2026
Co-authored-by: Rick Brouwer <[email protected]> Signed-off-by: Andrew Hall <[email protected]>
keda-automation
requested review from
a team
and removed request for
rickbrouwer
Member
|
/run-e2e prometheus |
rickbrouwer
approved these changes
Mar 6, 2026
rickbrouwer
added
the
Awaiting/2nd-approval
Member
|
/run-e2e prometheus |
zroubalik
approved these changes
Mar 31, 2026
akarki2005
pushed a commit
to akarki2005/keda
that referenced
this pull request
Apr 6, 2026
* Handle NaN result from Prometheus in the same way as handling Inf * Update CHANGELOG.md Co-authored-by: Rick Brouwer <[email protected]> Signed-off-by: Andrew Hall <[email protected]>
jansworld
pushed a commit
to jansworld/keda
that referenced
this pull request
Apr 10, 2026
* Handle NaN result from Prometheus in the same way as handling Inf * Update CHANGELOG.md Co-authored-by: Rick Brouwer <[email protected]> Signed-off-by: Andrew Hall <[email protected]> Signed-off-by: jansworld <[email protected]>
rickbrouwer
removed
the
Awaiting/2nd-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to address #7475.
When a Prometheus query is used for obtaining a scaler value the existing code will handle an Inf value being returned. However, if Prometheus returns a NaN this is not explicitly handled.
As a consequence, the NaN is parsed into a float64 and passed back for use in further evaluations.
This PR simply adds an additional test to ensure that NaN and Inf responses are handled in the same manner. This can result in arithmetic overflows and bogus
keda_scaler_metrics_valuebeing calculated.Checklist
make generate-scalers-schemahas been run to update any outdated generated filesFixes #7475