fix(fallback): check updated status for fallback condition instead of scaledObject#7490

Merged

rickbrouwer merged 4 commits into

kedacore:mainfrom

Sayrus:use-new-status

Mar 15, 2026

Sayrus commented Feb 26, 2026 •

edited

Loading

Contributor

In updateStatus on fallback, Health is checked against the current ScaledObject instead of the newly built health status. This means that Fallback status is only be updated on the next loop. This doesn't create any significant issue but can lead to some anomalies when reviewing ScaledObject statuses. This PR aims at fixing this by comparing the newly built status instead of the original one.

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added (if applicable)
Ensure make generate-scalers-schema has been run to update any outdated generated files
Changelog has been updated and is aligned with our changelog requirements, only when the change impacts end users
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #7488

Sayrus requested a review from a team as a code owner

February 26, 2026 15:34

github-actions Bot commented Feb 26, 2026

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

snyk-io Bot commented Feb 26, 2026 •

edited

Loading

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

keda-automation requested a review from a team

February 26, 2026 15:35

Sayrus force-pushed the use-new-status branch from f281f99 to 3e65b98 Compare

February 26, 2026 15:38

rickbrouwer commented Feb 27, 2026 •

edited by github-actions Bot

Loading

Member

/run-e2e fallback
Update: You can check the progress here

rickbrouwer approved these changes

View reviewed changes

rickbrouwer left a comment

Member

Thanks!

rickbrouwer added the Awaiting/2nd-approval label


          fix: use deepcopied and modified status to determine fallback condition

6cfadad

Signed-off-by: Mathis Raguin <[email protected]>

Sayrus force-pushed the use-new-status branch from 3e65b98 to 6cfadad Compare

February 27, 2026 15:20

keda-automation requested a review from a team

February 27, 2026 15:20

rickbrouwer commented Feb 27, 2026 •

edited by github-actions Bot

Loading

Member

/run-e2e fallback
Update: You can check the progress here

Sayrus mentioned this pull request

fix: reset fallback condition on idle scalers #7489

Closed

8 tasks

rickbrouwer changed the title ~~fix: use deepcopied and modified status to determine fallback condition~~ fix(fallback): check updated status for fallback condition instead of scaledObject

rickbrouwer enabled auto-merge (squash)

March 9, 2026 16:32

rickbrouwer requested changes

View reviewed changes

CHANGELOG.md Outdated


          Update CHANGELOG.md

19c3a83

Signed-off-by: Rick Brouwer <[email protected]>

rickbrouwer commented Mar 9, 2026 •

edited by github-actions Bot

Loading

Member

/run-e2e fallback
Update: You can check the progress here

rickbrouwer approved these changes

View reviewed changes

keda-automation requested a review from a team

March 9, 2026 16:34


          Merge branch 'main' into use-new-status

e57a082

rickbrouwer commented Mar 9, 2026 •

edited by github-actions Bot

Loading

Member

/run-e2e fallback
Update: You can check the progress here


          Merge branch 'main' into use-new-status

29c6a9b

Signed-off-by: Rick Brouwer <[email protected]>

rickbrouwer commented Mar 12, 2026 •

edited by github-actions Bot

Loading

Member

/run-e2e fallback
Update: You can check the progress here

JorTurFer approved these changes

View reviewed changes

rickbrouwer merged commit 1c6c09b into kedacore:main

44 of 47 checks passed

rickbrouwer removed the Awaiting/2nd-approval label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet