feat: create oauth2 auth trigger, integrate it with rabbitmq scaler by KyriosGN0 · Pull Request #7454 · kedacore/keda

KyriosGN0 · 2026-02-14T13:26:49Z

Provide a description of what has been changed

This PR add a new OAuth2 spec to to TriggerAuth crd, this spec will generate an access token that is returned to the scaler.
This PR also integrates this new spec to RabbitMQ scaler (currently only for http connection)
this allows people who use RabbitMQ with OAuth to use a timed access token instead of username/password

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added (if applicable)
Ensure make generate-scalers-schema has been run to update any outdated generated files
Changelog has been updated and is aligned with our changelog requirements, only when the change impacts end users
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #7379
Fixes #7525
Docs kedacore/keda-docs#1707

github-actions · 2026-02-14T13:26:59Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

snyk-io · 2026-02-14T13:27:03Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

zroubalik

Could you please also open docs PR (documenting both new TriggerAuth config and RabbitMQ)?

KyriosGN0 · 2026-03-10T08:38:12Z

hey @rickbrouwer, could you give my PR another look? Thanks!

KyriosGN0 · 2026-03-24T18:03:43Z

hey @rickbrouwer, could you look at the PR again? i fixed the changelog issue

KyriosGN0 · 2026-04-06T17:42:02Z

hey @rickbrouwer, small ping for this PR
Thanks in advance!

KyriosGN0 · 2026-04-06T19:27:03Z

btw @rickbrouwer do i need to open a PR to helm chart? i do modify the CRDs but i assume they are generated when a release is done right?

rickbrouwer · 2026-04-07T10:57:27Z

It all looks good to me! Great!
Do you think you could make an e2e so we can be sure it works?

KyriosGN0 · 2026-04-07T14:53:27Z

It all looks good to me! Great!

Do you think you could make an e2e so we can be sure it works?

I did test it locally to make sure this works, will add E2E test

KyriosGN0 · 2026-04-07T22:11:02Z

@rickbrouwer added E2E tests for it

rickbrouwer · 2026-04-09T14:44:11Z

can you check the semgrep findings?

KyriosGN0 · 2026-04-09T14:48:48Z

@rickbrouwer i see the same pattern in other tests as well

keda/tests/scalers/rabbitmq/rabbitmq_queue_amqp_auth/rabbitmq_queue_amqp_auth_test.go

Line 37 in 1f61143

    
           NoAuthConnectionString    = fmt.Sprintf("amqp://rabbitmq.%s.svc.cluster.local", rmqNamespace)

keda/tests/scalers/rabbitmq/rabbitmq_queue_http_auth/rabbitmq_queue_http_auth_test.go

Line 38 in 1f61143

    
           connectionString          = fmt.Sprintf("amqp://%s:%s@rabbitmq.%s.svc.cluster.local", user, password, rmqNamespace)

rickbrouwer · 2026-04-09T15:09:45Z

/run-e2e rabbit*
Update: You can check the progress here

Signed-off-by: AvivGuiser <[email protected]>

wozniakjan · 2026-05-25T08:00:08Z

/run-e2e rabbit
Update: You can check the progress here

passed tests: 14

Execution of tests/scalers/rabbitmq/rabbitmq_queue_http_dpratio/rabbitmq_queue_http_dpratio_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_http_regex/rabbitmq_queue_http_regex_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_http_regex_vhost/rabbitmq_queue_http_regex_vhost_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_http_aad_wi/rabbitmq_queue_http_aad_wi_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_http_vhost/rabbitmq_queue_http_vhost_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_http_eqct/rabbitmq_queue_http_eqct_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_http_regex_aad_wi/rabbitmq_queue_http_regex_aad_wi_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_http_dget/rabbitmq_queue_http_dget_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_http/rabbitmq_queue_http_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_amqp/rabbitmq_queue_amqp_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_amqp_vhost/rabbitmq_queue_amqp_vhost_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_http_oauth2/rabbitmq_queue_http_oauth2_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_amqp_auth/rabbitmq_queue_amqp_auth_test.go, has passed after "one" attempts
Execution of tests/scalers/rabbitmq/rabbitmq_queue_http_auth/rabbitmq_queue_http_auth_test.go, has passed after "one" attempts

failed tests: 0

changelog updated

…edacore#7454) * feat: create oauth2 auth trigger, integrate it with rabbitmq scaler Signed-off-by: AvivGuiser <[email protected]> * updated scaler-schema Signed-off-by: AvivGuiser <[email protected]> * update changelog Signed-off-by: AvivGuiser <[email protected]> * fix changelog and manifests Signed-off-by: AvivGuiser <[email protected]> * fix changelog Signed-off-by: AvivGuiser <[email protected]> * fix changelog Signed-off-by: AvivGuiser <[email protected]> * remove unrelated changes Signed-off-by: AvivGuiser <[email protected]> * remove unrelated changes Signed-off-by: AvivGuiser <[email protected]> * remove unrelated changes Signed-off-by: AvivGuiser <[email protected]> * fix conflicts Signed-off-by: AvivGuiser <[email protected]> * remvoe test files Signed-off-by: AvivGuiser <[email protected]> * validate the url is only http/https Signed-off-by: AvivGuiser <[email protected]> * remove revive rule from .golangci.yml Signed-off-by: AvivGuiser <[email protected]> * add E2E tests for rabbitmq oauth2 Signed-off-by: AvivGuiser <[email protected]> * fix unrelerated diffs after rebase Signed-off-by: AvivGuiser <[email protected]> * make clientSecret optional and make ClientCredential as default for type Signed-off-by: AvivGuiser <[email protected]> * update cluster trigger auth yml Signed-off-by: AvivGuiser <[email protected]> * block basic-auth and oauth2 in rabbitmq scaler, fix http client Signed-off-by: AvivGuiser <[email protected]> * remove webhook validation for client secret Signed-off-by: AvivGuiser <[email protected]> * update changelog.md Signed-off-by: AvivGuiser <[email protected]> * use authentication.OAuth and other fixes Signed-off-by: AvivGuiser <[email protected]> * update scalers-schema.yaml Signed-off-by: AvivGuiser <[email protected]> * fix conflicts Signed-off-by: AvivGuiser <[email protected]> * update changelog.md Signed-off-by: AvivGuiser <[email protected]> --------- Signed-off-by: AvivGuiser <[email protected]> Signed-off-by: AvivGuiser <[email protected]> Signed-off-by: Yurii Shcherbak <[email protected]>

KyriosGN0 requested a review from a team as a code owner February 14, 2026 13:26

keda-automation requested a review from a team February 14, 2026 13:27

KyriosGN0 mentioned this pull request Feb 14, 2026

suppport generic oauth2 in RabbitMQ scaler #7379

Closed

rickbrouwer previously requested changes Feb 16, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

keda-automation requested a review from a team February 16, 2026 19:09

KyriosGN0 requested a review from rickbrouwer February 16, 2026 19:09

zroubalik reviewed Feb 18, 2026

View reviewed changes

Comment thread pkg/scalers/liiklus/LiiklusService_grpc.pb.go Outdated

keda-automation requested a review from a team February 25, 2026 22:01

KyriosGN0 force-pushed the rmq-oauth2 branch from 58982c4 to 571f928 Compare March 2, 2026 15:34

rickbrouwer mentioned this pull request Mar 10, 2026

Add AWS IAM/OAuth2 Authentication Support for RabbitMQ Scaler (Amazon MQ) #7525

Closed

rickbrouwer reviewed Apr 6, 2026

View reviewed changes

Comment thread .golangci.yml Outdated

Comment thread apis/keda/v1alpha1/triggerauthentication_webhook.go Outdated

KyriosGN0 force-pushed the rmq-oauth2 branch from f1548e9 to 098051b Compare April 6, 2026 18:42

keda-automation requested a review from a team April 6, 2026 18:42

KyriosGN0 requested review from rickbrouwer and zroubalik April 6, 2026 19:00

semgrep-code-kedacore Bot reviewed Apr 7, 2026

View reviewed changes

Comment thread tests/scalers/rabbitmq/rabbitmq_queue_http_oauth2/rabbitmq_queue_http_oauth2_test.go

semgrep-code-kedacore Bot reviewed Apr 7, 2026

View reviewed changes

Comment thread tests/scalers/rabbitmq/rabbitmq_queue_http_oauth2/rabbitmq_queue_http_oauth2_test.go

KyriosGN0 force-pushed the rmq-oauth2 branch from d47c120 to dc6ef10 Compare April 9, 2026 14:39

KyriosGN0 and others added 17 commits May 25, 2026 09:56

remove unrelated changes

c8fb008

Signed-off-by: AvivGuiser <[email protected]>

remove unrelated changes

3dcc69d

Signed-off-by: AvivGuiser <[email protected]>

fix conflicts

3f36066

Signed-off-by: AvivGuiser <[email protected]>

remvoe test files

149b020

Signed-off-by: AvivGuiser <[email protected]>

validate the url is only http/https

9c8fcb5

Signed-off-by: AvivGuiser <[email protected]>

remove revive rule from .golangci.yml

970979b

Signed-off-by: AvivGuiser <[email protected]>

add E2E tests for rabbitmq oauth2

a32c801

Signed-off-by: AvivGuiser <[email protected]>

fix unrelerated diffs after rebase

1e2402b

Signed-off-by: AvivGuiser <[email protected]>

make clientSecret optional and make ClientCredential as default for type

d8b0ada

Signed-off-by: AvivGuiser <[email protected]>

update cluster trigger auth yml

ab53542

Signed-off-by: AvivGuiser <[email protected]>

block basic-auth and oauth2 in rabbitmq scaler, fix http client

501b8b7

Signed-off-by: AvivGuiser <[email protected]>

remove webhook validation for client secret

5a51e80

Signed-off-by: AvivGuiser <[email protected]>

update changelog.md

dbc5280

Signed-off-by: AvivGuiser <[email protected]>

use authentication.OAuth and other fixes

42520cd

Signed-off-by: AvivGuiser <[email protected]>

update scalers-schema.yaml

19a1d53

Signed-off-by: AvivGuiser <[email protected]>

fix conflicts

a4d70fa

Signed-off-by: AvivGuiser <[email protected]>

update changelog.md

1453768

Signed-off-by: AvivGuiser <[email protected]>

wozniakjan force-pushed the rmq-oauth2 branch from 62352de to 1453768 Compare May 25, 2026 07:56

wozniakjan enabled auto-merge (squash) May 25, 2026 08:20

wozniakjan approved these changes May 25, 2026

View reviewed changes

wozniakjan added the Awaiting/2nd-approval This PR needs one more approval review label May 25, 2026

rickbrouwer approved these changes May 25, 2026

View reviewed changes

rickbrouwer added waiting-for-e2e and removed Awaiting/2nd-approval This PR needs one more approval review labels May 25, 2026

wozniakjan merged commit 6330ba5 into kedacore:main May 25, 2026
26 checks passed

wozniakjan mentioned this pull request May 25, 2026

Migrate datadog, graphite and github_runner to authentication.Config #7766

Open

JorTurFer mentioned this pull request May 25, 2026

Generic OAuth2 tokens provider declaration #4694

Closed

Uh oh!

Conversation

KyriosGN0 commented Feb 14, 2026 • edited by wozniakjan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions Bot commented Feb 14, 2026

Uh oh!

snyk-io Bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

Uh oh!

zroubalik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KyriosGN0 commented Mar 10, 2026

Uh oh!

KyriosGN0 commented Mar 24, 2026

Uh oh!

KyriosGN0 commented Apr 6, 2026

Uh oh!

Uh oh!

Uh oh!

KyriosGN0 commented Apr 6, 2026

Uh oh!

rickbrouwer commented Apr 7, 2026

Uh oh!

KyriosGN0 commented Apr 7, 2026

Uh oh!

Uh oh!

Uh oh!

KyriosGN0 commented Apr 7, 2026

Uh oh!

rickbrouwer commented Apr 9, 2026

Uh oh!

KyriosGN0 commented Apr 9, 2026

Uh oh!

rickbrouwer commented Apr 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wozniakjan commented May 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

KyriosGN0 commented Feb 14, 2026 •

edited by wozniakjan

Loading

snyk-io Bot commented Feb 14, 2026 •

edited

Loading

rickbrouwer commented Apr 9, 2026 •

edited by github-actions Bot

Loading

wozniakjan commented May 25, 2026 •

edited by github-actions Bot

Loading