Skip to content

Refactor huawei cloudeye scaler#6978

Merged
zroubalik merged 1 commit into
kedacore:mainfrom
rickbrouwer:huawei
Aug 19, 2025
Merged

Refactor huawei cloudeye scaler#6978
zroubalik merged 1 commit into
kedacore:mainfrom
rickbrouwer:huawei

Conversation

@rickbrouwer

@rickbrouwer rickbrouwer commented Aug 12, 2025

Copy link
Copy Markdown
Member

Refactor the scaler to match the new metadata guidelines.

Good review required, because there is no e2e test for the Huawei Cloudeye scaler.

Because there is a deprecate announcement in it I will create a changelog item and the items according the deprecation policy.

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Changelog has been updated and is aligned with our [changelog requirements]
  • Tests have been added
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #5797
Docs: kedacore/keda-docs#1610

@github-actions

Copy link
Copy Markdown

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

@rickbrouwer rickbrouwer marked this pull request as draft August 12, 2025 19:07

@JorTurFer JorTurFer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the parameters one by one and I don't see any typo 😄

@JorTurFer

Copy link
Copy Markdown
Member

/skip-e2e

@zroubalik zroubalik merged commit 9204b23 into kedacore:main Aug 19, 2025
24 checks passed
@rickbrouwer rickbrouwer deleted the huawei branch August 19, 2025 08:42
@rickbrouwer

rickbrouwer commented Aug 19, 2025

Copy link
Copy Markdown
Member Author

Hi @wozniakjan / @JorTurFer

Can you add a deprecation announcement on GitHub Discussions

I'm not allowed to do that yet.

jmickey pushed a commit to jmickey/keda that referenced this pull request Aug 22, 2025
@JorTurFer

Copy link
Copy Markdown
Member

I've updated the role but I'm not sure if this permissions will be enough (I've added all permissions related with discussions, so I hope it so), have a try and I'll open it if you still can't

@rickbrouwer

Copy link
Copy Markdown
Member Author

I've updated the role but I'm not sure if this permissions will be enough (I've added all permissions related with discussions, so I hope it so), have a try and I'll open it if you still can't

Unfortunately, I don't get the option

@JorTurFer

Copy link
Copy Markdown
Member

The it looks that it's not possible if the person doesn't have admin/maintainer permission explicitly set 😢
I'm going to create it right now

@JorTurFer

Copy link
Copy Markdown
Member

#7014

dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
Signed-off-by: Rick Brouwer <[email protected]>
Signed-off-by: David Pochopsky <[email protected]>
alt-dima pushed a commit to alt-dima/keda that referenced this pull request Dec 13, 2025
Signed-off-by: Rick Brouwer <[email protected]>
Signed-off-by: Dmitriy Altuhov <[email protected]>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants