Skip to content

refactor: rename temporal scaler files for consistency#6911

Merged
JorTurFer merged 3 commits into
kedacore:mainfrom
aniruddhc1:rename-temporal-scaler
Jul 27, 2025
Merged

refactor: rename temporal scaler files for consistency#6911
JorTurFer merged 3 commits into
kedacore:mainfrom
aniruddhc1:rename-temporal-scaler

Conversation

@aniruddhc1

@aniruddhc1 aniruddhc1 commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

Renames the temporal scaler files to follow the convention used by other scalers in the project.

Renames the temporal scaler files to follow the convention used by other scalers in the project.

Checklist

Fixes #

Relates to #

@aniruddhc1
aniruddhc1 force-pushed the rename-temporal-scaler branch 4 times, most recently from 4c1e94e to 72bf857 Compare July 17, 2025 03:13
Renames the temporal scaler files to follow the  convention used by other scalers in the project.

-  ->
-  ->
-  ->

Signed-off-by: Aniruddh Chaturvedi <[email protected]>
@aniruddhc1
aniruddhc1 force-pushed the rename-temporal-scaler branch from 72bf857 to ab530c4 Compare July 17, 2025 04:05
@rickbrouwer

Copy link
Copy Markdown
Member

Thanks! This PR is related to discussion here: kedacore/keda-docs#1574

@rickbrouwer

rickbrouwer commented Jul 17, 2025

Copy link
Copy Markdown
Member

Hi @aniruddhc1 ,

Could you revert this file rename (tests/scalers/temporal_scaler/temporal_scaler_test.go)?
Because this one is in line with the rest.

@aniruddhc1
aniruddhc1 force-pushed the rename-temporal-scaler branch 2 times, most recently from 47aec46 to 15dc6ef Compare July 24, 2025 14:18
Signed-off-by: Aniruddh Chaturvedi <[email protected]>

@rickbrouwer rickbrouwer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aniruddhc1

Copy link
Copy Markdown
Contributor Author

Looks like I need one more reviewer to merge this PR. @rickbrouwer , could you find me someone?

@rickbrouwer

Copy link
Copy Markdown
Member

No worries, someone will pick it up soon :)

@JorTurFer
JorTurFer enabled auto-merge (squash) July 27, 2025 21:16
@JorTurFer

Copy link
Copy Markdown
Member

/skip-e2e

@JorTurFer
JorTurFer disabled auto-merge July 27, 2025 21:19
@JorTurFer
JorTurFer merged commit 8a999fc into kedacore:main Jul 27, 2025
24 checks passed
kmoonwright pushed a commit to kmoonwright/keda that referenced this pull request Jul 29, 2025
* refactor: rename temporal scaler files for consistency

Renames the temporal scaler files to follow the  convention used by other scalers in the project.

-  ->
-  ->
-  ->

Signed-off-by: Aniruddh Chaturvedi <[email protected]>

* address feedback

Signed-off-by: Aniruddh Chaturvedi <[email protected]>

---------

Signed-off-by: Aniruddh Chaturvedi <[email protected]>
Signed-off-by: Aniruddh Chaturvedi <[email protected]>
Signed-off-by: kmoonwright <[email protected]>
dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
* refactor: rename temporal scaler files for consistency

Renames the temporal scaler files to follow the  convention used by other scalers in the project.

-  ->
-  ->
-  ->

Signed-off-by: Aniruddh Chaturvedi <[email protected]>

* address feedback

Signed-off-by: Aniruddh Chaturvedi <[email protected]>

---------

Signed-off-by: Aniruddh Chaturvedi <[email protected]>
Signed-off-by: Aniruddh Chaturvedi <[email protected]>
Signed-off-by: David Pochopsky <[email protected]>
alt-dima pushed a commit to alt-dima/keda that referenced this pull request Dec 13, 2025
* refactor: rename temporal scaler files for consistency

Renames the temporal scaler files to follow the  convention used by other scalers in the project.

-  ->
-  ->
-  ->

Signed-off-by: Aniruddh Chaturvedi <[email protected]>

* address feedback

Signed-off-by: Aniruddh Chaturvedi <[email protected]>

---------

Signed-off-by: Aniruddh Chaturvedi <[email protected]>
Signed-off-by: Aniruddh Chaturvedi <[email protected]>
Signed-off-by: Dmitriy Altuhov <[email protected]>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025
* refactor: rename temporal scaler files for consistency

Renames the temporal scaler files to follow the  convention used by other scalers in the project.

-  ->
-  ->
-  ->

Signed-off-by: Aniruddh Chaturvedi <[email protected]>

* address feedback

Signed-off-by: Aniruddh Chaturvedi <[email protected]>

---------

Signed-off-by: Aniruddh Chaturvedi <[email protected]>
Signed-off-by: Aniruddh Chaturvedi <[email protected]>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026
* refactor: rename temporal scaler files for consistency

Renames the temporal scaler files to follow the  convention used by other scalers in the project.

-  ->
-  ->
-  ->

Signed-off-by: Aniruddh Chaturvedi <[email protected]>

* address feedback

Signed-off-by: Aniruddh Chaturvedi <[email protected]>

---------

Signed-off-by: Aniruddh Chaturvedi <[email protected]>
Signed-off-by: Aniruddh Chaturvedi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants