Update hpaName in ScaledObject status when HPA already exists#6860
Merged
Conversation
justinmir
force-pushed
the
fix-hpaName-missing
branch
from
June 23, 2025 18:07
739263b to
87fdcb2
Compare
When the ScaledObject adopts an HPA or if the hpaName in the ScaledObject status is removed for any reason, the hpaName status will no longer get set. It is only set when the HPA is created by the ScaledObject. We add setting the HPA name in the ScaledObject status to the regular reconciliation loop for the ScaledObject. See kedacore#6336 Signed-off-by: Justin Miron <[email protected]>
justinmir
force-pushed
the
fix-hpaName-missing
branch
from
June 23, 2025 18:18
87fdcb2 to
a07e849
Compare
justinmir
marked this pull request as ready for review
June 23, 2025 18:59
JorTurFer
approved these changes
Jun 28, 2025
Member
|
/run-e2e internal |
Member
|
nice catch! ❤️ |
kmoonwright
pushed a commit
to kmoonwright/keda
that referenced
this pull request
Jul 9, 2025
…re#6860) When the ScaledObject adopts an HPA or if the hpaName in the ScaledObject status is removed for any reason, the hpaName status will no longer get set. It is only set when the HPA is created by the ScaledObject. We add setting the HPA name in the ScaledObject status to the regular reconciliation loop for the ScaledObject. See kedacore#6336 Signed-off-by: Justin Miron <[email protected]> Signed-off-by: kmoonwright <[email protected]>
kmoonwright
pushed a commit
to kmoonwright/keda
that referenced
this pull request
Jul 9, 2025
…re#6860) When the ScaledObject adopts an HPA or if the hpaName in the ScaledObject status is removed for any reason, the hpaName status will no longer get set. It is only set when the HPA is created by the ScaledObject. We add setting the HPA name in the ScaledObject status to the regular reconciliation loop for the ScaledObject. See kedacore#6336 Signed-off-by: Justin Miron <[email protected]> Signed-off-by: kmoonwright <[email protected]>
kmoonwright
pushed a commit
to kmoonwright/keda
that referenced
this pull request
Jul 9, 2025
…re#6860) When the ScaledObject adopts an HPA or if the hpaName in the ScaledObject status is removed for any reason, the hpaName status will no longer get set. It is only set when the HPA is created by the ScaledObject. We add setting the HPA name in the ScaledObject status to the regular reconciliation loop for the ScaledObject. See kedacore#6336 Signed-off-by: Justin Miron <[email protected]> Signed-off-by: kmoonwright <[email protected]>
dpochopsky
pushed a commit
to dpochopsky/keda
that referenced
this pull request
Sep 12, 2025
…re#6860) When the ScaledObject adopts an HPA or if the hpaName in the ScaledObject status is removed for any reason, the hpaName status will no longer get set. It is only set when the HPA is created by the ScaledObject. We add setting the HPA name in the ScaledObject status to the regular reconciliation loop for the ScaledObject. See kedacore#6336 Signed-off-by: Justin Miron <[email protected]> Signed-off-by: David Pochopsky <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ScaledObject adopts an HPA or if the hpaName in the ScaledObject status is removed for any reason, the hpaName status will no longer get set. It is only set when the HPA is created by the ScaledObject.
We add setting the HPA name in the ScaledObject status to the regular reconciliation loop for the ScaledObject.
See #6336
Checklist
Fixes #6336