Require the same version we replace for prometheus#6806
Merged
Conversation
GraceAtwood
marked this pull request as draft
May 30, 2025 14:17
GraceAtwood
force-pushed
the
atwood-require-prometheus
branch
from
May 30, 2025 14:20
2367af4 to
6356695
Compare
…dependencies Signed-off-by: Grace Atwood <[email protected]>
GraceAtwood
force-pushed
the
atwood-require-prometheus
branch
from
May 30, 2025 14:22
6356695 to
bfee109
Compare
GraceAtwood
marked this pull request as ready for review
May 30, 2025 14:29
JorTurFer
approved these changes
Jun 1, 2025
Member
|
Thanks! |
dpochopsky
pushed a commit
to dpochopsky/keda
that referenced
this pull request
Sep 12, 2025
…dependencies (kedacore#6806) Signed-off-by: Grace Atwood <[email protected]> Signed-off-by: David Pochopsky <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey yall! We recently took a dependency on
github.com/kedacore/keda/v2But that's now causing all our IDEs to break with
seems like it's due to this line here
keda/go.mod
Line 80 in e23ef46
I asked that ^ question in Slack and @JorTurFer asked that I open this PR
Provide a description of what has been changed
So this just changes the require line to match what we're replacing so that when downstream projects take a dependency on keda, they don't import a bad version.
Checklist
Relates to #
https://kubernetes.slack.com/archives/CKZJ36A5D/p1747927855084599