New SolarWinds Observability Scaler by gantrior · Pull Request #6577 · kedacore/keda

gantrior · 2025-02-28T14:21:10Z

Added SolarWinds Observability scaler

Using go version of SolarWinds Observability SDK: https://github.com/solarwinds/swo-sdk-go/tree/main/swov1 to get data

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6576

PR to docs: kedacore/keda-docs#1545

TODOs:

Add E2E tests
Add PR to Docs

zroubalik

Great adddition, just FYI we plan to ship a new KEDA release in coming days (in case you would like to have this feature in)

gantrior · 2025-03-06T15:44:25Z

Great adddition, just FYI we plan to ship a new KEDA release in coming days (in case you would like to have this feature in)

I would be happy to ship it in the release, unfortunatelly at the moment I do not have time to complete E2E testing part. I will work out the remaining TODOs as soon as I can and properly verify it, It is ok to have it as part of the next release.

zroubalik · 2025-03-06T17:40:09Z

Great adddition, just FYI we plan to ship a new KEDA release in coming days (in case you would like to have this feature in)

I would be happy to ship it in the release, unfortunatelly at the moment I do not have time to complete E2E testing part. I will work out the remaining TODOs as soon as I can and properly verify it, It is ok to have it as part of the next release.

Not a problem, I completely understand. (Un)fortunately we have a policy to not merge scalers without e2e tests coverage. If we don't hit this release, we can definitely merge it in the next one.

stale · 2025-05-16T09:48:10Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

gantrior · 2025-05-16T10:28:13Z

For reference more discussion here: #6576

stale · 2025-05-23T15:10:53Z

This issue has been automatically closed due to inactivity.

Signed-off-by: Tomas Panik <[email protected]>

gantrior · 2025-07-07T21:37:30Z

I fixed all the issues and updated PR.

@zroubalik Could you please run E2E tests for solarwinds scaler?

rickbrouwer · 2025-07-09T13:20:20Z

/run-e2e solarwinds
Update: You can check the progress here

zroubalik · 2025-07-21T15:16:48Z

/run-e2e solarwinds
Update: You can check the progress here

Signed-off-by: Tomas Panik <[email protected]>

gantrior · 2025-07-22T16:41:57Z

@zroubalik After some troubleshooting I figured out why the E2E test is failing, and updated scaler. The E2E test should pass now, can you please re-run?

rickbrouwer · 2025-09-09T08:20:38Z

/run-e2e solarwinds
Update: You can check the progress here

Signed-off-by: Tomas Panik <[email protected]>

rickbrouwer · 2025-09-10T07:51:58Z

/run-e2e solarwinds
Update: You can check the progress here

Copilot

Pull Request Overview

This PR introduces a new SolarWinds Observability scaler for KEDA that enables autoscaling based on metrics from the SolarWinds Observability platform. It uses the official SolarWinds SDK to query metrics and make scaling decisions.

New scaler implementation with support for metric aggregation, filtering, and configurable intervals
Comprehensive test suite including unit tests and E2E integration tests
Integration with KEDA's scaler builder system

Reviewed Changes

Copilot reviewed 7 out of 233 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/scalers/solarwinds_scaler.go	Core scaler implementation using SolarWinds SDK
pkg/scalers/solarwinds_scaler_test.go	Unit tests for metadata parsing and metric specification
pkg/scaling/scalers_builder.go	Registration of new scaler in KEDA's builder
tests/scalers/solarwinds/solarwinds_test.go	E2E integration tests with scale out/in scenarios
tests/.env	Environment variables for SolarWinds API configuration
go.mod	Added SolarWinds SDK dependency
CHANGELOG.md	Documentation of new scaler addition

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Co-authored-by: Copilot <[email protected]> Signed-off-by: Tomas Panik <[email protected]>

Signed-off-by: Tomas Panik <[email protected]>

gantrior · 2025-09-25T08:54:17Z

@zroubalik I fixed generated schema for new scaler, can you please take a look?

zroubalik · 2025-09-26T19:45:43Z

/run-e2e solarwinds
Update: You can check the progress here

Signed-off-by: Tomas Panik <[email protected]>

gantrior · 2025-09-29T09:10:10Z

I fixed the merge conflicts. @zroubalik would it be possible to merge this and include it into upcoming release 2.18.0?

rickbrouwer · 2025-09-29T09:39:07Z

/run-e2e solarwinds
Update: You can check the progress here

rickbrouwer · 2025-10-01T07:13:43Z

I'm sorry, but there are again merge conflicts....

rickbrouwer · 2025-10-01T09:09:10Z

/run-e2e solarwinds
Update: You can check the progress here

* feat: add `solarwinds` scaler Signed-off-by: Tomas Panik <[email protected]> * feat: Fixing E2E tests Signed-off-by: Tomas Panik <[email protected]> * feat: Fixing order in changelog Signed-off-by: Tomas Panik <[email protected]> * feat: fixing solarwinds scaler tests Signed-off-by: Tomas Panik <[email protected]> * feat: making GetMetricsAndActivity cleaner and fixing Changelog Signed-off-by: Tomas Panik <[email protected]> * feat: adding triggerIndex as suggested in code review Signed-off-by: Tomas Panik <[email protected]> * feat: fixing E2E tests Signed-off-by: Tomas Panik <[email protected]> * feat: static analysis fix Signed-off-by: Tomas Panik <[email protected]> * improving error handling Co-authored-by: Copilot <[email protected]> Signed-off-by: Tomas Panik <[email protected]> * feat: updating schema Signed-off-by: Tomas Panik <[email protected]> * feat: Updating go.sum after merge Signed-off-by: Tomas Panik <[email protected]> --------- Signed-off-by: Tomas Panik <[email protected]> Signed-off-by: Tomas Panik <[email protected]> Co-authored-by: Copilot <[email protected]> Signed-off-by: Dmitriy Altuhov <[email protected]>

* feat: add `solarwinds` scaler Signed-off-by: Tomas Panik <[email protected]> * feat: Fixing E2E tests Signed-off-by: Tomas Panik <[email protected]> * feat: Fixing order in changelog Signed-off-by: Tomas Panik <[email protected]> * feat: fixing solarwinds scaler tests Signed-off-by: Tomas Panik <[email protected]> * feat: making GetMetricsAndActivity cleaner and fixing Changelog Signed-off-by: Tomas Panik <[email protected]> * feat: adding triggerIndex as suggested in code review Signed-off-by: Tomas Panik <[email protected]> * feat: fixing E2E tests Signed-off-by: Tomas Panik <[email protected]> * feat: static analysis fix Signed-off-by: Tomas Panik <[email protected]> * improving error handling Co-authored-by: Copilot <[email protected]> Signed-off-by: Tomas Panik <[email protected]> * feat: updating schema Signed-off-by: Tomas Panik <[email protected]> * feat: Updating go.sum after merge Signed-off-by: Tomas Panik <[email protected]> --------- Signed-off-by: Tomas Panik <[email protected]> Signed-off-by: Tomas Panik <[email protected]> Co-authored-by: Copilot <[email protected]>

gantrior changed the title ~~feat: add solarwinds scaler~~ New SolarWinds Observability Scaler Feb 28, 2025

gantrior force-pushed the feat/solarwinds-scaler branch 2 times, most recently from e6ac597 to 5c3a3a4 Compare March 3, 2025 08:28

gantrior mentioned this pull request Mar 3, 2025

Support SolarWinds Scaler #6576

Closed

zroubalik reviewed Mar 5, 2025

View reviewed changes

stale Bot added the stale All issues that are marked as stale due to inactivity label May 16, 2025

stale Bot closed this May 23, 2025

zroubalik reopened this Jul 2, 2025

stale Bot removed the stale All issues that are marked as stale due to inactivity label Jul 2, 2025

gantrior force-pushed the feat/solarwinds-scaler branch 3 times, most recently from 547e838 to 33a4a72 Compare July 7, 2025 11:38

feat: add solarwinds scaler

0068120

Signed-off-by: Tomas Panik <[email protected]>

gantrior force-pushed the feat/solarwinds-scaler branch from 33a4a72 to 0068120 Compare July 7, 2025 20:46

gantrior marked this pull request as ready for review July 7, 2025 21:33

Merge branch 'main' into feat/solarwinds-scaler

c175f70

rickbrouwer reviewed Jul 9, 2025

View reviewed changes

Comment thread pkg/scalers/solarwinds_scaler.go Outdated

gantrior added 2 commits July 22, 2025 18:36

feat: Fixing E2E tests

1942ebc

Signed-off-by: Tomas Panik <[email protected]>

Merge commit 'c175f7' into feat/solarwinds-scaler

927ca8a

gantrior force-pushed the feat/solarwinds-scaler branch from 737865f to 927ca8a Compare July 22, 2025 16:37

Merge remote-tracking branch 'origin/main' into feat/solarwinds-scaler

ebe7661

gantrior requested review from JorTurFer and zroubalik September 9, 2025 07:54

feat: fixing E2E tests

b54d82f

Signed-off-by: Tomas Panik <[email protected]>

gantrior force-pushed the feat/solarwinds-scaler branch from e687fbd to b54d82f Compare September 10, 2025 06:36

feat: static analysis fix

7e5846b

Signed-off-by: Tomas Panik <[email protected]>

zroubalik requested a review from Copilot September 18, 2025 10:08

Copilot AI reviewed Sep 18, 2025

View reviewed changes

Comment thread pkg/scalers/solarwinds_scaler.go Outdated

Comment thread go.mod

Comment thread go.mod

zroubalik mentioned this pull request Sep 18, 2025

Release: 2.18.0 #6853

Closed

22 tasks

JorTurFer approved these changes Sep 18, 2025

View reviewed changes

improving error handling

3bddf25

Co-authored-by: Copilot <[email protected]> Signed-off-by: Tomas Panik <[email protected]>

keda-automation requested a review from a team September 22, 2025 08:42

gantrior and others added 2 commits September 22, 2025 10:45

Merge branch 'main' into feat/solarwinds-scaler

67251b8

feat: updating schema

86ef571

Signed-off-by: Tomas Panik <[email protected]>

gantrior added 2 commits September 29, 2025 10:56

Merge remote-tracking branch 'origin/main' into feat/solarwinds-scaler

24f7ade

feat: Updating go.sum after merge

fa403bf

Signed-off-by: Tomas Panik <[email protected]>

Merge remote-tracking branch 'origin/main' into feat/solarwinds-scaler

b586815

rickbrouwer added the ok-to-merge This PR can be merged label Oct 1, 2025

wozniakjan approved these changes Oct 1, 2025

View reviewed changes

wozniakjan merged commit 46c2933 into kedacore:main Oct 1, 2025
25 checks passed

Uh oh!

Conversation

gantrior commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

zroubalik left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gantrior commented Mar 6, 2025

Uh oh!

zroubalik commented Mar 6, 2025

Uh oh!

stale Bot commented May 16, 2025

Uh oh!

gantrior commented May 16, 2025

Uh oh!

stale Bot commented May 23, 2025

Uh oh!

gantrior commented Jul 7, 2025

Uh oh!

Uh oh!

rickbrouwer commented Jul 9, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zroubalik commented Jul 21, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gantrior commented Jul 22, 2025

Uh oh!

rickbrouwer commented Sep 9, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Sep 10, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gantrior commented Sep 25, 2025

Uh oh!

zroubalik commented Sep 26, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gantrior commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Sep 29, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Oct 1, 2025

Uh oh!

rickbrouwer commented Oct 1, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gantrior commented Feb 28, 2025 •

edited

Loading

zroubalik left a comment •

edited

Loading

rickbrouwer commented Jul 9, 2025 •

edited by github-actions Bot

Loading

zroubalik commented Jul 21, 2025 •

edited by github-actions Bot

Loading

rickbrouwer commented Sep 9, 2025 •

edited by github-actions Bot

Loading

rickbrouwer commented Sep 10, 2025 •

edited by github-actions Bot

Loading

zroubalik commented Sep 26, 2025 •

edited by github-actions Bot

Loading

gantrior commented Sep 29, 2025 •

edited

Loading

rickbrouwer commented Sep 29, 2025 •

edited by github-actions Bot

Loading

rickbrouwer commented Oct 1, 2025 •

edited by github-actions Bot

Loading