Skip to content

refactor liklus scaler#6433

Merged
JorTurFer merged 3 commits into
kedacore:mainfrom
omerap12:refactor_liklus_scaler
Jan 18, 2025
Merged

refactor liklus scaler#6433
JorTurFer merged 3 commits into
kedacore:mainfrom
omerap12:refactor_liklus_scaler

Conversation

@omerap12

@omerap12 omerap12 commented Dec 20, 2024 •
edited by wozniakjan
Loading

Copy link
Copy Markdown
Contributor

refactor liiklus scaler metadata parsing

Checklist

Relates to #5797

@omerap12 omerap12 requested a review from a team as a code owner December 20, 2024 09:00
@omerap12
refactor liklus scaler
56f8d4a 
Signed-off-by: Omer Aplatony <[email protected]>
@omerap12 omerap12 force-pushed the refactor_liklus_scaler branch from cfe52d7 to 56f8d4a Compare December 20, 2024 11:11
wozniakjan
wozniakjan reviewed Dec 20, 2024
View reviewed changes

@wozniakjan wozniakjan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! just a few minor details below

Comment thread pkg/scalers/liiklus_scaler.go Outdated
Comment thread pkg/scalers/liiklus_scaler_test.go Outdated
Comment thread pkg/scalers/liiklus_scaler.go
@omerap12
Fix unit test for scaling
4934fd0 
Signed-off-by: Omer Aplatony <[email protected]>
JorTurFer
JorTurFer reviewed Dec 22, 2024
View reviewed changes

@JorTurFer JorTurFer left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these const still required?

const (
	defaultLiiklusLagThreshold           int64 = 10
	defaultLiiklusActivationLagThreshold int64 = 0
)
const (
	liiklusLagThresholdMetricName           = "lagThreshold"
	liiklusActivationLagThresholdMetricName = "activationLagThreshold"
)

@omerap12

omerap12 commented Dec 22, 2024

Copy link
Copy Markdown
Contributor Author

Are these const still required?

const (
	defaultLiiklusLagThreshold           int64 = 10
	defaultLiiklusActivationLagThreshold int64 = 0
)
const (
	liiklusLagThresholdMetricName           = "lagThreshold"
	liiklusActivationLagThresholdMetricName = "activationLagThreshold"
)

I only use them in _test.go, so I believe they can be removed.

@omerap12
Removed unused constants
9924ef1 
Signed-off-by: Omer Aplatony <[email protected]>
@omerap12

omerap12 commented Jan 2, 2025

Copy link
Copy Markdown
Contributor Author

friendly ping @JorTurFer @wozniakjan :)

@wozniakjan

wozniakjan commented Jan 2, 2025

Copy link
Copy Markdown
Member

/skip-e2e

@JorTurFer JorTurFer merged commit 6340991 into kedacore:main Jan 18, 2025
@dttung2905 dttung2905 mentioned this pull request Oct 16, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zroubalik zroubalik zroubalik approved these changes
@wozniakjan wozniakjan wozniakjan approved these changes
@JorTurFer JorTurFer JorTurFer approved these changes

Assignees

No one assigned

Labels

skip-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@omerap12 @wozniakjan @zroubalik @JorTurFer @keda-automation