Skip to content

Refactor AWS DynamoDB Streams scaler configuration#6351

Merged
wozniakjan merged 4 commits into
kedacore:mainfrom
omerap12:refactor_aws_dynamodb_streams_scaler
Nov 27, 2024
Merged

Refactor AWS DynamoDB Streams scaler configuration#6351
wozniakjan merged 4 commits into
kedacore:mainfrom
omerap12:refactor_aws_dynamodb_streams_scaler

Conversation

@omerap12

Copy link
Copy Markdown
Contributor

Refactor DynamoDB Streams scaler configuration

Checklist

Relates to #5797

@omerap12 omerap12 requested a review from a team as a code owner November 20, 2024 15:54
@wozniakjan

wozniakjan commented Nov 20, 2024

Copy link
Copy Markdown
Member

/run-e2e aws_dynamodb
Update: You can check the progress here

Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
@omerap12

Copy link
Copy Markdown
Contributor Author

/run-e2e aws_dynamodb Update: You can check the progress here

Friendly ping :)

@wozniakjan wozniakjan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan

wozniakjan commented Nov 26, 2024

Copy link
Copy Markdown
Member

/run-e2e aws_dynamodb
Update: You can check the progress here

Comment thread pkg/scalers/aws_dynamodb_streams_scaler_test.go
@wozniakjan wozniakjan enabled auto-merge (squash) November 27, 2024 09:24
@wozniakjan wozniakjan merged commit 2adbc81 into kedacore:main Nov 27, 2024
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <[email protected]>

* fixed unit tests

Signed-off-by: Omer Aplatony <[email protected]>

* Fix invalid value test

Signed-off-by: Omer Aplatony <[email protected]>

* go fmt

Signed-off-by: Omer Aplatony <[email protected]>

---------

Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: michael pechner <[email protected]>
robpickerill pushed a commit to robpickerill/keda that referenced this pull request Nov 30, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <[email protected]>

* fixed unit tests

Signed-off-by: Omer Aplatony <[email protected]>

* Fix invalid value test

Signed-off-by: Omer Aplatony <[email protected]>

* go fmt

Signed-off-by: Omer Aplatony <[email protected]>

---------

Signed-off-by: Omer Aplatony <[email protected]>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <[email protected]>

* fixed unit tests

Signed-off-by: Omer Aplatony <[email protected]>

* Fix invalid value test

Signed-off-by: Omer Aplatony <[email protected]>

* go fmt

Signed-off-by: Omer Aplatony <[email protected]>

---------

Signed-off-by: Omer Aplatony <[email protected]>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <[email protected]>

* fixed unit tests

Signed-off-by: Omer Aplatony <[email protected]>

* Fix invalid value test

Signed-off-by: Omer Aplatony <[email protected]>

* go fmt

Signed-off-by: Omer Aplatony <[email protected]>

---------

Signed-off-by: Omer Aplatony <[email protected]>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <[email protected]>

* fixed unit tests

Signed-off-by: Omer Aplatony <[email protected]>

* Fix invalid value test

Signed-off-by: Omer Aplatony <[email protected]>

* go fmt

Signed-off-by: Omer Aplatony <[email protected]>

---------

Signed-off-by: Omer Aplatony <[email protected]>
ctccxxd pushed a commit to ctccxxd/keda that referenced this pull request Dec 10, 2024
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <[email protected]>

* fixed unit tests

Signed-off-by: Omer Aplatony <[email protected]>

* Fix invalid value test

Signed-off-by: Omer Aplatony <[email protected]>

* go fmt

Signed-off-by: Omer Aplatony <[email protected]>

---------

Signed-off-by: Omer Aplatony <[email protected]>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Jan 2, 2025
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <[email protected]>

* fixed unit tests

Signed-off-by: Omer Aplatony <[email protected]>

* Fix invalid value test

Signed-off-by: Omer Aplatony <[email protected]>

* go fmt

Signed-off-by: Omer Aplatony <[email protected]>

---------

Signed-off-by: Omer Aplatony <[email protected]>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
* Refactor AWS DynamoDB Streams scaler configuration

Signed-off-by: Omer Aplatony <[email protected]>

* fixed unit tests

Signed-off-by: Omer Aplatony <[email protected]>

* Fix invalid value test

Signed-off-by: Omer Aplatony <[email protected]>

* go fmt

Signed-off-by: Omer Aplatony <[email protected]>

---------

Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants