Skip to content

Refactor Cassandra scaler#6275

Merged
JorTurFer merged 2 commits into
kedacore:mainfrom
rickbrouwer:cassandra
Nov 3, 2024
Merged

Refactor Cassandra scaler#6275
JorTurFer merged 2 commits into
kedacore:mainfrom
rickbrouwer:cassandra

Conversation

@rickbrouwer

@rickbrouwer rickbrouwer commented Oct 27, 2024

Copy link
Copy Markdown
Member
  • Refactor the scaler to match the new metadata guidelines.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 27, 2024 13:42
@rickbrouwer rickbrouwer marked this pull request as draft October 27, 2024 13:53
Signed-off-by: rickbrouwer <[email protected]>
@rickbrouwer rickbrouwer marked this pull request as ready for review October 27, 2024 15:56
@wozniakjan

wozniakjan commented Oct 28, 2024

Copy link
Copy Markdown
Member

/run-e2e cassandra
Update: You can check the progress here

Comment thread pkg/scalers/cassandra_scaler.go Outdated
Comment thread pkg/scalers/cassandra_scaler.go
Signed-off-by: rickbrouwer <[email protected]>
@wozniakjan

wozniakjan commented Oct 29, 2024

Copy link
Copy Markdown
Member

/run-e2e cassandra
Update: You can check the progress here

@wozniakjan wozniakjan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@JorTurFer JorTurFer merged commit b34fad0 into kedacore:main Nov 3, 2024
@rickbrouwer rickbrouwer deleted the cassandra branch November 4, 2024 11:09
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
* Refactor cassandra scaler

Signed-off-by: rickbrouwer <[email protected]>

* Update feedback

Signed-off-by: rickbrouwer <[email protected]>

---------

Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: michael pechner <[email protected]>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
* Refactor cassandra scaler

Signed-off-by: rickbrouwer <[email protected]>

* Update feedback

Signed-off-by: rickbrouwer <[email protected]>

---------

Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants