Skip to content

Refactor couchdb scaler#6267

Merged
JorTurFer merged 2 commits into
kedacore:mainfrom
rickbrouwer:couch
Nov 3, 2024
Merged

Refactor couchdb scaler#6267
JorTurFer merged 2 commits into
kedacore:mainfrom
rickbrouwer:couch

Conversation

@rickbrouwer

Copy link
Copy Markdown
Member
  • Refactor the scaler to match the new metadata guidelines.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 24, 2024 11:03
@rickbrouwer rickbrouwer marked this pull request as draft October 24, 2024 11:03
@rickbrouwer rickbrouwer force-pushed the couch branch 2 times, most recently from 0072175 to 3447c7f Compare October 24, 2024 11:20
Signed-off-by: rickbrouwer <[email protected]>
@rickbrouwer rickbrouwer marked this pull request as ready for review October 24, 2024 11:47
@SpiritZhou

SpiritZhou commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

/run-e2e couchdb
Update: You can check the progress here

@wozniakjan wozniakjan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

minor nit below

Comment thread pkg/scalers/couchdb_scaler.go Outdated
Signed-off-by: rickbrouwer <[email protected]>
@wozniakjan

wozniakjan commented Oct 31, 2024

Copy link
Copy Markdown
Member

/run-e2e couchdb
Update: You can check the progress here

@JorTurFer JorTurFer merged commit baec715 into kedacore:main Nov 3, 2024
@rickbrouwer rickbrouwer deleted the couch branch November 4, 2024 11:09
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
* Refactor couchdb scaler

Signed-off-by: rickbrouwer <[email protected]>

* Update

Signed-off-by: rickbrouwer <[email protected]>

---------

Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: michael pechner <[email protected]>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
* Refactor couchdb scaler

Signed-off-by: rickbrouwer <[email protected]>

* Update

Signed-off-by: rickbrouwer <[email protected]>

---------

Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants