Refactor InfluxDB scaler config#6240
Merged
Merged
Conversation
JorTurFer
approved these changes
Oct 16, 2024
JorTurFer
left a comment
JorTurFer
left a comment
Member
There was a problem hiding this comment.
Looking good, just a single type inline. PTAL @wozniakjan
wozniakjan
approved these changes
Oct 21, 2024
Member
There was a problem hiding this comment.
lgtm, thank you!
fwiw, the unit test failure seems to be related to #6246
Member
|
/run-e2e influx |
Signed-off-by: wangrushen <[email protected]>
Signed-off-by: wangrushen <[email protected]>
Member
|
/run-e2e influx |
58 tasks
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 21, 2024
* Refactor InfluxDB scaler config Signed-off-by: wangrushen <[email protected]> * fix: typo in influxdv unsafessl Signed-off-by: wangrushen <[email protected]> --------- Signed-off-by: wangrushen <[email protected]>
mpechner-akasa
pushed a commit
to nrichardson-akasa/keda
that referenced
this pull request
Nov 29, 2024
* Refactor InfluxDB scaler config Signed-off-by: wangrushen <[email protected]> * fix: typo in influxdv unsafessl Signed-off-by: wangrushen <[email protected]> --------- Signed-off-by: wangrushen <[email protected]> Signed-off-by: michael pechner <[email protected]>
chiragbhatia8
pushed a commit
to chiragbhatia8/keda
that referenced
this pull request
Jan 9, 2025
* Refactor InfluxDB scaler config Signed-off-by: wangrushen <[email protected]> * fix: typo in influxdv unsafessl Signed-off-by: wangrushen <[email protected]> --------- Signed-off-by: wangrushen <[email protected]> Signed-off-by: Chirag Bhatia <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the scaler to match the new metadata guidelines.
Checklist
Fixes #
Related: #5797