Skip to content

Fix some incorrect parameter parsing in Gitlab Runner #6173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zroubalik merged 2 commits into from
Oct 18, 2024
Merged

Fix some incorrect parameter parsing in Gitlab Runner #6173

zroubalik merged 2 commits into from
Oct 18, 2024

Conversation

@dovics
Copy link
Contributor

@dovics dovics commented Sep 18, 2024 •
edited by zroubalik
Loading

Provide a description of what has been changed

  1. Fix null pointer when runnerScopeFromEnv or ownerFromEnv environment variable is empty
  2. Expose parsing errors when applicationID or installationID isn't int, and refine error reporting

Checklist

Fixes #6156
Fixes #6159

@dovics dovics requested a review from a team as a code owner September 18, 2024 09:03
@dovics dovics changed the title fix: panic when owner or runnerScope env is empty Fix some incorrect parameter parsing in Gitlab Runner Sep 20, 2024
@JorTurFer
Copy link
Member

JorTurFer commented Oct 6, 2024 •
edited by github-actions bot
Loading

/run-e2e github
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) October 6, 2024 21:10
@zroubalik zroubalik disabled auto-merge October 18, 2024 12:09
zroubalik
zroubalik approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zroubalik zroubalik merged commit 67358af into kedacore:main Oct 18, 2024
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
@dovics @rickbrouwer
Fix some incorrect parameter parsing in Gitlab Runner (kedacore#6173)
79e0af0 
Signed-off-by: wangrushen <[email protected]>
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
@dovics @mpechner-akasa
Fix some incorrect parameter parsing in Gitlab Runner (kedacore#6173)
14b3ee6 
Signed-off-by: wangrushen <[email protected]>
Signed-off-by: michael pechner <[email protected]>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
@dovics @chiragbhatia8
Fix some incorrect parameter parsing in Gitlab Runner (kedacore#6173)
41a6d8f 
Signed-off-by: wangrushen <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@dovics @JorTurFer @zroubalik