Refactor cron scaler config#6098
Merged
Merged
Conversation
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
rickbrouwer
changed the title
Member
Author
|
Hi @wozniakjan I've also refactored the cron scaler to match the new metadata guidelines. Can you please take a quick look at the code to make sure that it's matches the new metadata guidelines? 🙏 |
Signed-off-by: Rick Brouwer <[email protected]>
wozniakjan
approved these changes
Aug 22, 2024
wozniakjan
left a comment
wozniakjan
left a comment
Member
There was a problem hiding this comment.
lgtm, this is perfect!
Thank you so much @rickbrouwer ❤️
Member
|
/run-e2e |
Member
Author
|
@wozniakjan I think only the run-e2e for cron must run, but maybe I'm wrong |
Member
you are right, thanks for reminding me :) |
Member
|
/run-e2e cron |
Member
|
I think this is ok to merge, ptal @kedacore/keda-contributors |
3 tasks
JorTurFer
approved these changes
Aug 28, 2024
4 tasks
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Oct 7, 2024
Signed-off-by: Rick Brouwer <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
58 tasks
mpechner-akasa
pushed a commit
to nrichardson-akasa/keda
that referenced
this pull request
Nov 29, 2024
Signed-off-by: Rick Brouwer <[email protected]> Signed-off-by: michael pechner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Related: 5797