Add support for cross tenant authentication azure workload identity TriggerAuthentication #5517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldotyu
force-pushed
the
main
branch
4 times, most recently
from
61eeef5 to
a9326d9
Compare
Signed-off-by: Paul Yu <[email protected]>
JorTurFer
reviewed
Feb 23, 2024
Member
|
/run-e2e azure |
pauldotyu
commented
Feb 24, 2024
JorTurFer
approved these changes
Feb 26, 2024
Member
JorTurFer
left a comment
JorTurFer
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution ❤️
Member
|
Could you solve DCO issue? If you click on the link you will get an explanation about how to solve it :) |
Signed-off-by: Paul Yu <[email protected]>
Contributor
Author
My bad. I keep forgetting to sign my commits 😆 It should be resolved now. |
Member
|
/run-e2e azure |
Member
|
/run-e2e azure |
JorTurFer
reviewed
Feb 29, 2024
Member
|
/run-e2e aws |
Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Paul Yu <[email protected]>
JorTurFer
reviewed
Feb 29, 2024
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Member
|
/run-e2e aws Update: You can check the progress here |
Member
|
/run-e2e aws |
Member
|
Wonderful! |
SpiritZhou
pushed a commit
to SpiritZhou/keda
that referenced
this pull request
Mar 15, 2024
…riggerAuthentication (kedacore#5517) Signed-off-by: Paul Yu <[email protected]> Signed-off-by: Paul Yu <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable cross-tenant and cross-cloud authentication when using the
azure-workloadPodIdentityProvider within TriggerAuthentication.Checklist
Fixes #5441
Relates to #