Prometheus Scaler: Remove trailing whitespaces in customAuthHeader and customAuthValue #4959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
Amir-Wollman
force-pushed
the
remove-custom-auth-newline
branch
3 times, most recently
from
81e78ac to
ebdb572
Compare
…pdate CHANGELOG Signed-off-by: Amir-Wollman <[email protected]>
Amir-Wollman
force-pushed
the
remove-custom-auth-newline
branch
from
ebdb572 to
d436bbd
Compare
JorTurFer
approved these changes
Sep 11, 2023
Member
|
/run-e2e prometheus |
JorTurFer
reviewed
Sep 11, 2023
Member
|
Thanks for the contribution! Could you merge the suggestion? Static checks are failing |
Fix whitespace at the end of CHANGELOG.md file Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Amir-Wollman <[email protected]>
Member
|
/run-e2e prometheus @JorTurFer : I have canceled this because it hasn't started yet and there is other commit |
zroubalik
reviewed
Sep 11, 2023
Member
zroubalik
left a comment
zroubalik
left a comment
There was a problem hiding this comment.
Looking good! Just a nit in the Changelog
Modify CHANGELOG entry to use correct parameter names Signed-off-by: Amir-Wollman <[email protected]>
Member
|
/run-e2e prometheus |
JorTurFer
changed the title
JorTurFer
changed the title
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
…d customAuthValue (kedacore#4959) Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: anton.lysina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added strings.TrimSuffix to customAuth interpreter to avoid auth failure.
*TrimSuffix was used rather than TrimSpace to avoid unwanted removal of randomly generated strings with "\n"
Checklist
Relates to #
https://kubernetes.slack.com/archives/CKZJ36A5D/p1694069463138859
Fixes #4960