Skip to content

fix: Skip Resolving Secrets From Restricted Namespace #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zroubalik merged 1 commit into from
Jun 27, 2023
Merged

fix: Skip Resolving Secrets From Restricted Namespace #4735

zroubalik merged 1 commit into from
Jun 27, 2023

Conversation

@Indresh2410
Copy link
Contributor

@Indresh2410 Indresh2410 commented Jun 24, 2023 •
edited
Loading

Provide a description of what has been changed

Checklist

Fixes #4519

Relates to #

@Indresh2410 Indresh2410 requested a review from a team as a code owner June 24, 2023 06:23
@github-actions
Copy link

github-actions bot commented Jun 24, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@Indresh2410 Indresh2410 mentioned this pull request Jun 24, 2023
Closed
@Indresh2410
Copy link
Contributor Author

Indresh2410 commented Jun 24, 2023

resolver % export KEDA_RESTRICT_SECRET_ACCESS=true
resolver % export KEDA_CLUSTER_OBJECT_NAMESPACE=keda
resolver % GOOS="darwin" go test -v
=== RUN TestGetPropertiesForCloud
--- PASS: TestGetPropertiesForCloud (0.00s)
=== RUN TestEnvWithRestrictSecretAccess
=== RUN TestEnvWithRestrictSecretAccess/env_reference_secret_key
=== RUN TestEnvWithRestrictSecretAccess/env_reference_secret_name
--- PASS: TestEnvWithRestrictSecretAccess (0.00s)
--- PASS: TestEnvWithRestrictSecretAccess/env_reference_secret_key (0.00s)
--- PASS: TestEnvWithRestrictSecretAccess/env_reference_secret_name (0.00s)
=== RUN TestEnvWithRestrictedNamespace
=== RUN TestEnvWithRestrictedNamespace/env_reference_secret_key
=== RUN TestEnvWithRestrictedNamespace/env_reference_secret_name
--- PASS: TestEnvWithRestrictedNamespace (0.00s)
--- PASS: TestEnvWithRestrictedNamespace/env_reference_secret_key (0.00s)
--- PASS: TestEnvWithRestrictedNamespace/env_reference_secret_name (0.00s)
PASS
ok github.com/kedacore/keda/v2/pkg/scaling/resolver 2.947s
`

zroubalik
zroubalik requested changes Jun 24, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Indresh2410 the static check is failing, there's a whitespace end the end of the new line in Makefile

 diff --git a/Makefile b/Makefile
index 21e3aab..f6bfed8 100644
--- a/Makefile
+++ b/Makefile
Error: @@ -173,7 +173,7 @@ pkg/mock/mock_scaler/mock_scaler.go: pkg/scalers/scaler.go
 	$(MOCKGEN) -destination=$@ -package=mock_scalers -source=$^
Error:  pkg/mock/mock_secretlister/mock_interfaces.go: vendor/k8s.io/client-go/listers/core/v1/secret.go
 	mkdir -p pkg/mock/mock_secretlister
-	$(MOCKGEN) k8s.io/client-go/listers/core/v1 SecretLister,SecretNamespaceLister > $@	
+	$(MOCKGEN) k8s.io/client-go/listers/core/v1 SecretLister,SecretNamespaceLister > $@

@zroubalik
Copy link
Member

zroubalik commented Jun 26, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Jun 26, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@Indresh2410 Indresh2410 force-pushed the fix-restrict-secret-access branch from 50cc12d to 5850a74 Compare June 26, 2023 13:49
@zroubalik
Copy link
Member

zroubalik commented Jun 26, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

zroubalik
zroubalik approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Indresh2410
Copy link
Contributor Author

Indresh2410 commented Jun 27, 2023

Hi @zroubalik . e2e tests are oscillating . Don't see any issues wrt test cases. Any suggestion on this?

@zroubalik
Copy link
Member

zroubalik commented Jun 27, 2023 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@zroubalik zroubalik merged commit 406c358 into kedacore:main Jun 27, 2023
@zroubalik
Copy link
Member

zroubalik commented Jun 27, 2023

Thanks @Indresh2410 !

tomkerkhove pushed a commit that referenced this pull request Jun 28, 2023
@Indresh2410 @tomkerkhove
fix: Skip Resolving Secrets From Restricted Namespace (#4735)
507cacb 
Signed-off-by: Indresh-Prakash <[email protected]>
tomkerkhove added a commit that referenced this pull request Jun 29, 2023
@tomkerkhove @JorTurFer @Indresh2410
chore: Cherry-pick fixes for KEDA v2.11.1 (#4744)
62d90e8 
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Co-authored-by: Indresh2410 <[email protected]>
fix: Skip Resolving Secrets From Restricted Namespace (#4735)
@JorTurFer JorTurFer mentioned this pull request Jun 29, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KEDA tries to resolve secrets from restricted namespace

2 participants

@Indresh2410 @zroubalik