Skip to content

feat(Scaler): Adds Solr Scaler#4355

Merged
zroubalik merged 11 commits intokedacore:mainfrom
emircanagac:solr-scaler
Mar 23, 2023
Merged

feat(Scaler): Adds Solr Scaler#4355
zroubalik merged 11 commits intokedacore:mainfrom
emircanagac:solr-scaler

Conversation

@emircanagac
Copy link
Copy Markdown
Contributor

@emircanagac emircanagac commented Mar 12, 2023 •
edited by tomkerkhove
Loading

Provide a description of what has been changed
+Adds Solr Scaler for autoscaling based on solr queries

Checklist

Relates to #4234
Relates to kedacore/keda-docs#1093

@emircanagac emircanagac requested a review from a team as a code owner March 12, 2023 19:22
@emircanagac
feat(Scaler): Adds Solr Scaler
34732cd 
Signed-off-by: ithesadson <[email protected]>
@emircanagac
fix pre-commit errors
432548b 
Signed-off-by: ithesadson <[email protected]>
@emircanagac
edit changelog.md
d7b2297 
Signed-off-by: ithesadson <[email protected]>
@emircanagac
Copy link
Copy Markdown
Contributor Author

emircanagac commented Mar 14, 2023

Hi @tomkerkhove , I wrote the scaler and it seems to be working.
If everything is ok and you approve, I can start writing the document.

@zroubalik
Copy link
Copy Markdown
Member

zroubalik commented Mar 14, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@emircanagac
increase scale out time
0148edf 
Signed-off-by: ithesadson <[email protected]>
@emircanagac
Copy link
Copy Markdown
Contributor Author

emircanagac commented Mar 17, 2023

@zroubalik Can you trigger the e2e test again, I increased the time given for scale up

@zroubalik
Copy link
Copy Markdown
Member

zroubalik commented Mar 17, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@zroubalik
Copy link
Copy Markdown
Member

zroubalik commented Mar 17, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@zroubalik
Copy link
Copy Markdown
Member

zroubalik commented Mar 18, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@emircanagac emircanagac mentioned this pull request Mar 18, 2023
Merged
1 task
@emircanagac
Copy link
Copy Markdown
Contributor Author

emircanagac commented Mar 18, 2023

I added the document for solr scaler. kedacore/keda-docs#1093

tomkerkhove
tomkerkhove reviewed Mar 20, 2023
View reviewed changes
@zroubalik
Copy link
Copy Markdown
Member

zroubalik commented Mar 20, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@emircanagac
Copy link
Copy Markdown
Contributor Author

emircanagac commented Mar 20, 2023

@zroubalik Can you please trigger to run the CI/validate - amd64 (pull_request) test again?

@tomkerkhove
Copy link
Copy Markdown
Member

tomkerkhove commented Mar 21, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@zroubalik
Copy link
Copy Markdown
Member

zroubalik commented Mar 21, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

zroubalik
zroubalik approved these changes Mar 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@zroubalik zroubalik merged commit 078c51b into kedacore:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zroubalik zroubalik zroubalik approved these changes

+1 more reviewer

@tomkerkhove tomkerkhove tomkerkhove left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emircanagac @zroubalik @tomkerkhove