fix: Added port information check in ClusterIPAddress#4162
Merged
zroubalik merged 4 commits intokedacore:mainfrom Feb 6, 2023
Merged
fix: Added port information check in ClusterIPAddress#4162zroubalik merged 4 commits intokedacore:mainfrom
zroubalik merged 4 commits intokedacore:mainfrom
Conversation
Signed-off-by: ithesadson <[email protected]>
zroubalik
reviewed
Jan 30, 2023
Signed-off-by: ithesadson <[email protected]>
Member
|
/run-e2e cassandra* |
zroubalik
approved these changes
Jan 30, 2023
Member
zroubalik
left a comment
zroubalik
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
zroubalik
requested changes
Jan 30, 2023
Member
zroubalik
left a comment
zroubalik
left a comment
There was a problem hiding this comment.
One more thing, do you think you can add unit test for this fix? https://github.com/kedacore/keda/blob/main/pkg/scalers/cassandra_scaler_test.go
Signed-off-by: ithesadson <[email protected]>
Contributor
Author
|
I added the unit test. But e2e-tests has been running for about 5 days and has not finished yet. Is there any problem with my unit test? |
Member
|
/run-e2e cassandra* |
Member
|
@ithesadson maintainers need to start e2e tests, I've just triggered them |
Signed-off-by: Zbynek Roubalik <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ithesadson [email protected]
Since the change I made before was a breaking change, I just fix the mistake and send a pr again.
Issue : #4110
Previous PR: #4079
If the clusterIPAddress contains port information, checking if the port information is entered in the clusterIPAddress will cause some errors.
Error example in current code: User enters the following values.
clusterIPAddress: "https://cassandra.test/"
port: "9042"
->Expected clusterIPAddress : https://cassandra.test:9042/
The actual clusterIPAddress: https://cassandra.test/
Checklist