fix: scaleobject ready condition 'False/Unknow' to 'True' requeue#3097
Merged
Conversation
Signed-off-by: champly <[email protected]>
Signed-off-by: champly <[email protected]>
tomkerkhove
changed the title
champly
changed the title
Member
|
/run-e2e |
tomkerkhove
reviewed
Jun 2, 2022
tomkerkhove
left a comment
tomkerkhove
left a comment
Member
There was a problem hiding this comment.
Can you update the changelog please?
Signed-off-by: champly <[email protected]>
Contributor
Author
ok, already added, PTAL. |
Member
|
Thanks for the contribution! |
Member
|
/run-e2e |
Member
|
@champly do you think you can write some test for this scenario? |
Signed-off-by: champly <[email protected]>
Contributor
Author
ut have been added, and an |
Signed-off-by: champly <[email protected]>
zroubalik
reviewed
Jun 7, 2022
zroubalik
left a comment
zroubalik
left a comment
Member
There was a problem hiding this comment.
Looking good, nice!
The only thing, why the changed perms on the Azure scaler files?
Signed-off-by: champly <[email protected]>
Contributor
Author
|
Oh, it should be edited automatically by the editor, it has been revert. |
Member
|
/run-e2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: champly [email protected]
Provide a description of what has been changed
Checklist
Fixes #3096
Relates to #