fix: secret rbac in restricted mode with cert-manager enabled#856
Merged
wozniakjan merged 1 commit intoMay 27, 2026
Merged
Conversation
Signed-off-by: Jan Wozniak <[email protected]>
22 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the KEDA Helm chart where enabling restricted secret access together with cert-manager-managed certificates could cause the operator to fail due to missing RBAC to access the TLS secret it needs in its own namespace (reported in #743; previously addressed by #518).
Changes:
- Add a cert-manager-specific RBAC rule granting
geton the configured TLS secret. - When
permissions.operator.restrict.secret=true, additionally grant namespacedlist/watchonsecretsto support informer-based access in restricted mode. - Preserve the existing auto-generated-certs RBAC behavior via
else if certificates.autoGenerated.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rickbrouwer
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #505 got fixed by #518 but probably in some later refactor, this got reverted back and #743 reports this again. This should fix it.
Checklist
Fixes #743