fix(keda): don't gate cert rotation on metrics server being enabled#852
Merged
zroubalik merged 1 commit intoMay 27, 2026
Merged
Conversation
PR kedacore#819 added .Values.metricsServer.enabled to the --enable-cert-rotation gate, which means setting metricsServer.enabled=false also disables cert rotation for the operator and admission webhooks. The kedaorg-certs secret is then never created, leaving the operator crashlooping on missing /certs/ca.crt and webhooks stuck in ContainerCreating. Restore the pre-kedacore#819 expression so cert rotation is gated only on autoGenerated and !certManager.enabled, independent of the metrics server. Fixes kedacore#849 Signed-off-by: John Zammit <[email protected]>
Member
Contributor
Author
|
Can we merge this? |
Contributor
There was a problem hiding this comment.
Pull request overview
Restores KEDA operator/admission webhook certificate rotation behavior by removing the unintended dependency on metricsServer.enabled, ensuring cert generation/rotation still occurs when the metrics server is disabled.
Changes:
- Remove
.Values.metricsServer.enabledfrom the--enable-cert-rotationgating expression in the operator deployment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wozniakjan
approved these changes
May 27, 2026
wozniakjan
left a comment
wozniakjan
left a comment
Member
There was a problem hiding this comment.
thanks! yeah this was definitely an oversight
zroubalik
approved these changes
May 27, 2026
Member
|
@zammitjohn thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #819 added
.Values.metricsServer.enabledto the--enable-cert-rotationgate inkeda/templates/manager/deployment.yaml. As a result, settingmetricsServer.enabled=falsealso disables cert rotation for the operator and admission webhooks, so thekedaorg-certssecret is never created.Symptoms reported in #849:
open /certs/ca.crt: no such file or directoryContainerCreating:MountVolume.SetUp failed for volume "certificates": secret "kedaorg-certs" not foundScaledJobsnever start because the operator never becomes readyThis restores the pre-#819 expression so cert rotation is gated only on
autoGeneratedand!certManager.enabled, independent of the metrics server. The metrics server's own deployment andAPIServiceare still gated separately by{{- if .Values.metricsServer.enabled }}, so disabling it continues to work as intended.Verified via
helm template:truetruemetricsServer.enabled=falsefalse(bug)truecertManager.enabled=truefalsefalsecertificates.autoGenerated=falsefalsefalseChecklist
Fixes #849