ability to disable metrics server deployment#819
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Helm value to optionally disable deploying KEDA’s metrics server (and related external metrics API resources), intended for users who only need ScaledJobs.
Changes:
- Introduces
metricsServer.enabled(defaulttrue) in chart values and documents it in the README. - Wraps all metrics-server related templates (APIService, Deployment, Service, RBAC, monitors, network policies, PDB) with
metricsServer.enabled. - Adds/updates vendored packaged chart tarballs under
kedify-agent/charts/.
Reviewed changes
Copilot reviewed 14 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
keda/values.yaml |
Adds metricsServer.enabled value (default true). |
keda/README.md |
Documents the new metricsServer.enabled setting. |
keda/templates/metrics-server/apiservice.yaml |
Gates APIService creation on metricsServer.enabled. |
keda/templates/metrics-server/deployment.yaml |
Gates metrics server Deployment on metricsServer.enabled. |
keda/templates/metrics-server/service.yaml |
Gates metrics server Service on metricsServer.enabled. |
keda/templates/metrics-server/serviceaccount.yaml |
Gates metrics server ServiceAccount on metricsServer.enabled. |
keda/templates/metrics-server/clusterrole.yaml |
Gates metrics server ClusterRole on metricsServer.enabled. |
keda/templates/metrics-server/clusterrolebinding.yaml |
Gates metrics server RBAC bindings on metricsServer.enabled. |
keda/templates/metrics-server/networkpolicy.yaml |
Gates k8s NetworkPolicy on metricsServer.enabled. |
keda/templates/metrics-server/ciliumnetworkpolicy.yaml |
Gates CiliumNetworkPolicy on metricsServer.enabled. |
keda/templates/metrics-server/poddisruptionbudget.yaml |
Gates PDB on metricsServer.enabled. |
keda/templates/metrics-server/podmonitor.yaml |
Gates PodMonitor on metricsServer.enabled. |
keda/templates/metrics-server/servicemonitor.yaml |
Gates ServiceMonitor on metricsServer.enabled. |
keda/templates/manager/deployment.yaml |
Adjusts operator arg --enable-cert-rotation to consider metrics server enabled. |
kedify-agent/charts/kedify-predictor-v0.0.1.tgz |
Adds vendored packaged chart artifact. |
kedify-agent/charts/keda-add-ons-http-v0.11.0-0.tgz |
Adds vendored packaged chart artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JorTurFer
requested changes
Feb 18, 2026
JorTurFer
left a comment
JorTurFer
left a comment
Member
There was a problem hiding this comment.
I think that you have committed unexpected files xD
Signed-off-by: Zbynek Roubalik <[email protected]>
JorTurFer
approved these changes
Mar 15, 2026
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
approved these changes
Mar 18, 2026
4 tasks
zroubalik
pushed a commit
that referenced
this pull request
May 27, 2026
…852) PR #819 added .Values.metricsServer.enabled to the --enable-cert-rotation gate, which means setting metricsServer.enabled=false also disables cert rotation for the operator and admission webhooks. The kedaorg-certs secret is then never created, leaving the operator crashlooping on missing /certs/ca.crt and webhooks stuck in ContainerCreating. Restore the pre-#819 expression so cert rotation is gated only on autoGenerated and !certManager.enabled, independent of the metrics server. Fixes #849 Signed-off-by: John Zammit <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to not install Metrics Server - for example for users that want to use only ScaledJobs and are not insterested in ScaledObjects scaling.
Checklist