keda: DNS config consolidation#773
Merged
wozniakjan merged 1 commit intoAug 17, 2025
Merged
Conversation
Signed-off-by: Jan Wozniak <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates DNS configuration options for KEDA components by implementing a unified approach with fallback priority: component-specific dnsConfig takes precedence, followed by global dnsConfig, with no DNS config rendered if neither is defined.
- Adds component-specific
dnsConfigfields for operator and webhooks components - Implements fallback logic using Helm's
defaultfunction across all deployment templates - Removes duplicate DNS config rendering in metrics server template
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| keda/values.yaml | Adds dnsConfig fields for operator and webhooks, standardizes comments |
| keda/templates/webhooks/deployment.yaml | Implements DNS config fallback logic |
| keda/templates/metrics-server/deployment.yaml | Consolidates duplicate DNS config rendering with fallback logic |
| keda/templates/manager/deployment.yaml | Implements DNS config fallback logic for operator |
| keda/README.md | Updates documentation to reflect new DNS config options |
22 tasks
JorTurFer
approved these changes
Aug 17, 2025
jaina-git
pushed a commit
to jaina-git/charts
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Jain <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#772 and #771 both introduced configuration options for DNS config. This PR consolidates both approaches into a simpler unified form with priorities:
dnsConfigdnsConfigdnsConfigChecklist