feat(keda): Support for dnsConfig parameter#772
Merged
Conversation
wozniakjan
reviewed
Aug 1, 2025
wozniakjan
left a comment
wozniakjan
left a comment
Member
There was a problem hiding this comment.
lgtm, just minor nit
I suppose this may overlap with recently merged #771, you may need to rebase
nitinverma9
force-pushed
the
add-dnsConfig-support
branch
2 times, most recently
from
4f9e5c0 to
6a57576
Compare
Signed-off-by: Nitin Verma <[email protected]>
nitinverma9
force-pushed
the
add-dnsConfig-support
branch
from
6a57576 to
8eb3ee7
Compare
wozniakjan
approved these changes
Aug 1, 2025
Contributor
Author
|
Hey @wozniakjan can this be merged anytime soon? |
Member
|
this, along with #771, both added very similar fields, I guess we can merge it as is and I will try to unify the approach with regards to the dns options passing in a standalone PR charts/keda/templates/metrics-server/deployment.yaml Lines 187 to 189 in 8eb3ee7 charts/keda/templates/metrics-server/deployment.yaml Lines 191 to 194 in 8eb3ee7 |
3 tasks
|
This is exactly what I needed. Nice work. |
jaina-git
pushed a commit
to jaina-git/charts
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Nitin Verma <[email protected]> Signed-off-by: Jain <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes #