feat(http-add-on): allow setting extra environment variables#762
Closed
ilia-medvedev wants to merge 1 commit into
Closed
feat(http-add-on): allow setting extra environment variables#762ilia-medvedev wants to merge 1 commit into
ilia-medvedev wants to merge 1 commit into
Conversation
Signed-off-by: Ilia Medvedev <[email protected]>
|
Is there an ETA for merging this PR? I really want to set Thanks in advance EDIT: I just saw that the env var that I mentioned has not been included in a release of the http-add-on yet, and I assume it will be added when the release will be done |
wozniakjan
reviewed
Jul 25, 2025
Member
There was a problem hiding this comment.
this is a great addition, thank you!
can you please just make it follow the convention set by KEDA as implemented in #245. The extra args are configured on KEDA through key value map, e.g.
extraArgs:
interceptor:
arg1: val-for-arg1
arg2: "val for arg 2 with spaces"
|
The PR #245 is for startup arguments (extra args), this pr is for extra environment variables (as https://github.com/kedacore/charts/blob/main/keda/templates/manager/deployment.yaml#L173) env:
- name: KEDA_FOO
value: barWithout this PR, we can't activate metrics or tracing. |
robinderooij-rl
added a commit
to RosemanLabs/keda-charts
that referenced
this pull request
Sep 10, 2025
The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: kedacore#245) A previous PR was already made some time ago but it did not adhere to the requested convention: kedacore#762 This PR tries to solve that issue.
robinderooij-rl
added a commit
to RosemanLabs/keda-charts
that referenced
this pull request
Sep 10, 2025
The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: kedacore#245) A previous PR was already made some time ago but it did not adhere to the requested convention: kedacore#762 This PR tries to solve that issue. Signed-off-by: Robin de Rooij <[email protected]>
Contributor
|
Just for reference, I implemented it in the way @wozniakjan mentioned in #777 |
robinderooij-rl
added a commit
to RosemanLabs/keda-charts
that referenced
this pull request
Sep 30, 2025
The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: kedacore#245) A previous PR was already made some time ago but it did not adhere to the requested convention: kedacore#762 This PR tries to solve that issue. Signed-off-by: Robin de Rooij <[email protected]>
wozniakjan
approved these changes
Oct 6, 2025
wozniakjan
added a commit
that referenced
this pull request
Oct 6, 2025
* Add ability to add extra ENV vars to containers The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: #245) A previous PR was already made some time ago but it did not adhere to the requested convention: #762 This PR tries to solve that issue. Signed-off-by: Robin de Rooij <[email protected]> * Allow Keda to request SA tokens (#728) * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <[email protected]> * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <[email protected]> * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <[email protected]> --------- Signed-off-by: Bojan Zelic <[email protected]> Signed-off-by: Robin de Rooij <[email protected]> * Move global extraEnvs object to their components Signed-off-by: Robin de Rooij <[email protected]> * http-add-on: migrate v1.Endpoints to discoveryv1.EndpointSlices (#779) Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Robin de Rooij <[email protected]> * release http-add-on v0.11.0 (#780) Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Robin de Rooij <[email protected]> * Add to README Signed-off-by: Robin de Rooij <[email protected]> --------- Signed-off-by: Robin de Rooij <[email protected]> Signed-off-by: Bojan Zelic <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Co-authored-by: Bojan Zelic <[email protected]> Co-authored-by: Jan Wozniak <[email protected]>
Member
|
hey @robinderooij-rl, it seems like the PR has merge conflicts and is unable to merge as a result, can you please rebase on latest main? thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow setting custom environment variables for http-add-on components
Closes #761
Checklist
Fixes #