feat: support different node selector and toleration for operator, metric server and webhooks#758
Conversation
JorTurFer
left a comment
JorTurFer
left a comment
There was a problem hiding this comment.
Hello
We must avoid breaking changes. Please do it in a way that avoids breaking change, for example, defining this new fields under operator.tolerations, metrics-server.tolerations, etc and use the current value as default if the other isn't defined
Hi, i updated the PR accordingly |
|
hey @JorTurFer, can i get another review here? |
…tric server and webhooks Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
|
hey @JorTurFer, can i get another review here? |
JorTurFer
left a comment
JorTurFer
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution!
@wozniakjan PTAL
Sorry for the slow response btw 😿 |
|
@wozniakjan would it be possible to get your review here? Thanks and sorry for the ping |
|
hey @wozniakjan, gentle ping on this, Thanks! |
|
looks like this PR broke valid configuration for setting |
3 participants
Signed-off-by: AvivGuiser [email protected]
this PR introduces a new separate values for tolerations and node selector for metric server, operator, webhook.
i do think this is a breaking change, a way to maybe make it not a breaking change is to add the node selector and toleration under each spec (while keeping the global one) instead of doing a key per component under the nodeSelector and toleration spec.
let me know if you want me to implement it that way.
Checklist