Updating templates to remove blank annotations#486
Merged
Conversation
3e4dd79 to
6127f2e
Compare
Signed-off-by: emctl <[email protected]>
6127f2e to
3e08287
Compare
JorTurFer
approved these changes
Jun 29, 2023
JorTurFer
left a comment
Member
There was a problem hiding this comment.
Thanks for the improvement! ❤️
This was referenced Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the keda chart, I noticed that annotations can generate empty key's when no additional annotations are passed in e.g.
I am attempted to just alter the helm template logic to only create the annotation key should there be a value passed in. I have added a before and after yaml from running
helm templatelocally. I carried out some local testing where I passed in a number of different values (i.e. not justAdditionalAnnotations) and seemed ok to me.Checklist
Fixes #
Files for comparison:
beforeAfter.zip