Add extra container args config for both keda operator and metric server#245
Merged
Merged
Conversation
Signed-off-by: Marco Davalos <[email protected]>
serbixote
force-pushed
the
add-container-extra-args
branch
from
6c6d540 to
b1f879c
Compare
4 tasks
zroubalik
pushed a commit
to zroubalik/charts
that referenced
this pull request
Aug 14, 2025
Co-authored-by: Kedify Bot <[email protected]>
robinderooij-rl
added a commit
to RosemanLabs/keda-charts
that referenced
this pull request
Sep 10, 2025
The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: kedacore#245) A previous PR was already made some time ago but it did not adhere to the requested convention: kedacore#762 This PR tries to solve that issue.
robinderooij-rl
added a commit
to RosemanLabs/keda-charts
that referenced
this pull request
Sep 10, 2025
The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: kedacore#245) A previous PR was already made some time ago but it did not adhere to the requested convention: kedacore#762 This PR tries to solve that issue. Signed-off-by: Robin de Rooij <[email protected]>
robinderooij-rl
added a commit
to RosemanLabs/keda-charts
that referenced
this pull request
Sep 30, 2025
The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: kedacore#245) A previous PR was already made some time ago but it did not adhere to the requested convention: kedacore#762 This PR tries to solve that issue. Signed-off-by: Robin de Rooij <[email protected]>
wozniakjan
added a commit
that referenced
this pull request
Oct 6, 2025
* Add ability to add extra ENV vars to containers The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: #245) A previous PR was already made some time ago but it did not adhere to the requested convention: #762 This PR tries to solve that issue. Signed-off-by: Robin de Rooij <[email protected]> * Allow Keda to request SA tokens (#728) * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <[email protected]> * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <[email protected]> * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <[email protected]> --------- Signed-off-by: Bojan Zelic <[email protected]> Signed-off-by: Robin de Rooij <[email protected]> * Move global extraEnvs object to their components Signed-off-by: Robin de Rooij <[email protected]> * http-add-on: migrate v1.Endpoints to discoveryv1.EndpointSlices (#779) Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Robin de Rooij <[email protected]> * release http-add-on v0.11.0 (#780) Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Robin de Rooij <[email protected]> * Add to README Signed-off-by: Robin de Rooij <[email protected]> --------- Signed-off-by: Robin de Rooij <[email protected]> Signed-off-by: Bojan Zelic <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Co-authored-by: Bojan Zelic <[email protected]> Co-authored-by: Jan Wozniak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently neither the KEDA operator nor the metric server accept extra arguments in the KEDA chart. However, in some cases we may need to set additional arguments like when How do I run KEDA with readOnlyRootFilesystem=true ? as describe in the KEDA FAQs where metric-server flags are needed.
This change enables the user to be able to set additional container arguments when needed.
Checklist