Skip to content

#375 Add support for deleting offsets#392

Merged
C0urante merged 4 commits into
kcctl:mainfrom
mfvitale:375
Oct 17, 2023
Merged

#375 Add support for deleting offsets#392
C0urante merged 4 commits into
kcctl:mainfrom
mfvitale:375

Conversation

@mfvitale

@mfvitale mfvitale commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Closes: #375

Must be merged after #393 to let tests on TRUNK run

@mfvitale

Copy link
Copy Markdown
Contributor Author

@C0urante can you please take a look?

Comment thread src/main/java/org/kcctl/command/DeleteOffsetsCommand.java Outdated
Comment thread src/main/java/org/kcctl/command/DeleteOffsetsCommand.java Outdated
Comment thread src/test/java/org/kcctl/command/DeleteOffsetsCommandTest.java Outdated
Comment thread src/test/java/org/kcctl/command/DeleteOffsetsCommandTest.java Outdated
@mfvitale

Copy link
Copy Markdown
Contributor Author

@C0urante thanks for the suggestions. I have addressed it and also I have updated the Debezium version to 2.4.0.Final to use the new STOPPED state. If you want to have this update on separate PR, I can do it.

@C0urante C0urante left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mfvitale!

@C0urante C0urante merged commit 2fe580d into kcctl:main Oct 17, 2023
@C0urante

Copy link
Copy Markdown
Contributor

Regarding the bump in Debezium version--I'm fine with that in this PR 😄

It looks like we can also start work on #346 now that we're on a version of Debezium that has native support for the STOPPED state! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support deleting connector offsets

2 participants