#102 Support new task restart semantics#362
Merged
Merged
Conversation
C0urante
force-pushed
the
gh-102
branch
2 times, most recently
from
91e2f31 to
e2b94d1
Compare
C0urante
commented
Jul 31, 2023
Comment on lines
+74
to
+79
| @POST | ||
| @Path("/connectors/{name}/restart") | ||
| ConnectorStatusInfo restartConnectorAndTasks( | ||
| @PathParam("name") String name, | ||
| @QueryParam("includeTasks") boolean includeTasks, | ||
| @QueryParam("onlyFailed") boolean onlyFailed); |
Contributor
Author
There was a problem hiding this comment.
I really wanted to omit the includeTasks parameter here and hardcode it to be true in the REST request, but couldn't find a way to do that. Based on microprofile/microprofile-rest-client#315 it may not even be possible.
Collaborator
Good question. I don't think it's a huge burden for users to specify a value for |
Collaborator
|
Merged; thanks, @C0urante! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102
Usage:
I was toying with the idea of not requiring an argument to the
--tasksflag and defaulting toallin that case, but it seemed a little too complex for users. Still,kcctl restart connector -t file-sourcedoes feel noticeably less clunky thankcctl restart connector -t all file-source, so it'd be nice to hear other perspectives on whether that'd be worth supporting.