Skip to content

Release v2.5.0 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Art4 merged 3 commits into from
Feb 5, 2024
Merged

Release v2.5.0 #373

Art4 merged 3 commits into from
Feb 5, 2024

Conversation

@Art4
Copy link
Collaborator

@Art4 Art4 commented Feb 1, 2024

After merge of this PR we can tag and release v2.5.0.

@Art4 Art4 added this to the v2.5.0 milestone Feb 1, 2024
@codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab5f4eb) 97.51% compared to head (018f615) 97.51%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               v2.x     #373   +/-   ##
=========================================
  Coverage     97.51%   97.51%           
  Complexity      563      563           
=========================================
  Files            29       29           
  Lines          1607     1607           
=========================================
  Hits           1567     1567           
  Misses           40       40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4
Copy link
Collaborator Author

Art4 commented Feb 1, 2024

@kbsali I would like to add the codecov badge on the README and need the Graphing token from Codecov.io. What do you think? Would you be so kind? You can find it in the settings: https://app.codecov.io/gh/kbsali/php-redmine-api/settings

@Art4 Art4 requested a review from kbsali February 3, 2024 08:26
@Art4 Art4 self-assigned this Feb 3, 2024
kbsali
kbsali approved these changes Feb 3, 2024
View reviewed changes
Copy link
Owner

@kbsali kbsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Art4
Copy link
Collaborator Author

Art4 commented Feb 3, 2024

@kbsali What do you think about the Graphing token from Codecov.io?

@kbsali
Copy link
Owner

kbsali commented Feb 3, 2024

sorry, did not see you messag :) -> 4P6dAaDbJ9

@kbsali kbsali marked this pull request as ready for review February 4, 2024 14:20
kbsali
kbsali approved these changes Feb 4, 2024
View reviewed changes
Copy link
Owner

@kbsali kbsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Art4
Copy link
Collaborator Author

Art4 commented Feb 4, 2024

I'm not sure why it's not working...

https://codecov.io/gh/kbsali/php-redmine-api/graph/badge.svg?token=4P6dAaDbJ9 shows "unknown" state.

with my account it is working fine: https://codecov.io/gh/Art4/php-redmine-api/graph/badge.svg?token=GRBNS1Q16N

@kbsali
Copy link
Owner

kbsali commented Feb 4, 2024

it should be fixed, i had to setup the branch it points to :)

@Art4 Art4 merged commit 1eab8ca into kbsali:v2.x Feb 5, 2024
@Art4 Art4 deleted the release-2.5.0 branch February 5, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbsali kbsali kbsali approved these changes

Assignees

@Art4 Art4

Labels

None yet

Projects

None yet

Milestone

v2.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Art4 @kbsali