Add Request interface and rename Response::getBody()
#366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v2.x #366 +/- ##
============================================
- Coverage 96.84% 96.80% -0.04%
- Complexity 550 556 +6
============================================
Files 27 27
Lines 1523 1567 +44
============================================
+ Hits 1475 1517 +42
- Misses 48 50 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
HttpClient::request()method to allow handling implementation of the newRequestinterface, described in #341. It also renamesResponse::getBody()toResponse::getContent(), see #363.In the tests I introduced an
AssertingHttpClientthat allows us easily define aHttpClientwith asserted Requests and expected Responses. This will become very handy while starting deprecating theRedmine\Client\Clientinterface and replacing it in tests.