Skip to content

Comments

- Small improvements to repository to satisfy Kwalitee.#503

Open
manwar wants to merge 1 commit intokawamurashingo:mainfrom
manwar:minor-improvement-to-repo
Open

- Small improvements to repository to satisfy Kwalitee.#503
manwar wants to merge 1 commit intokawamurashingo:mainfrom
manwar:minor-improvement-to-repo

Conversation

@manwar
Copy link

@manwar manwar commented Jan 8, 2026

Hi @kawamurashingo

Please review the pull request.

  • Removed generated files from MANIFEST i.e. META.yml, META.json
  • Added clean key to Makefile.PL to allow dist file cleanup
  • Added provides to Makefile.PL

Many Thanks.

Best Regards,
Mohammad

@kawamurashingo
Copy link
Owner

Hi Mohammad,

Thanks! I found a couple of issues in the Makefile.PL diff:

  1. In provides, some file paths don’t match the actual repo files:
  • lib/JQ/Lite/Uti/Parsingl.pm should be lib/JQ/Lite/Util/Parsing.pm
  • lib/JQ/Lite/Util/Paths should be lib/JQ/Lite/Util/Paths.pm
  1. clean => { ... } looks like it ended up inside the provides block (and the braces don’t appear to close properly).
    clean should be a top-level argument to WriteMakefile, not inside META_MERGE/provides.

Also, could we avoid hard-coding the version in provides to keep it in sync with VERSION_FROM?

If you update the PR accordingly, I’ll merge it.

Best regards,
Shingo

@manwar manwar force-pushed the minor-improvement-to-repo branch from 405bc4e to 0c8809d Compare January 9, 2026 09:45
@manwar
Copy link
Author

manwar commented Jan 9, 2026

Hi @kawamurashingo,

Thanks for prompt review.

  1. I have fixed the typo in path for 'provides'.
  2. I have removed hardcode version too, now pulling it on the fly.

With regard to the key 'clean', it seems fine to me and not inside 'provides'.

Best Regards,
Mohammad

@kawamurashingo
Copy link
Owner

Thanks for the PR! This is a very helpful improvement for CPAN metadata, but there is one critical typo that needs to be fixed before merging.

There is a typo in Makefile.PL under the provides section:

'JQ::Lite::Util::Parsing' => { file => 'lib/JQ/Lite/Uti/Parsing.pm' },
                                      ^^^

It should be Util, not Uti:

'JQ::Lite::Util::Parsing' => { file => 'lib/JQ/Lite/Util/Parsing.pm' },

If this is merged as-is, the CPAN META will map the module to a non-existent file, which can break indexing and tooling.


Also, this PR removes META.yml and META.json from MANIFEST.
If the project expects these files to always be included in make dist tarballs, this change may be risky.
(If they are treated as generated artifacts only, then it’s fine, but it should be intentional.)


Suggestion

  • Fix UtiUtil (required)
  • Then merging is OK
  • Reconsider whether META.* should stay in MANIFEST based on release policy

Thanks — once the typo is fixed this PR looks good 👍

  - Added clean key to Makefile.PL to allow dist file cleanup
  - Added provides to Makefile.PL
@manwar manwar force-pushed the minor-improvement-to-repo branch from 0c8809d to 8a5006d Compare January 12, 2026 10:02
@manwar
Copy link
Author

manwar commented Jan 12, 2026

@kawamurashingo Point taken well, I have updated the pull request accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants