- Small improvements to repository to satisfy Kwalitee.#503
- Small improvements to repository to satisfy Kwalitee.#503manwar wants to merge 1 commit intokawamurashingo:mainfrom
Conversation
|
Hi Mohammad, Thanks! I found a couple of issues in the Makefile.PL diff:
Also, could we avoid hard-coding the version in If you update the PR accordingly, I’ll merge it. Best regards, |
405bc4e to
0c8809d
Compare
|
Hi @kawamurashingo, Thanks for prompt review.
With regard to the key 'clean', it seems fine to me and not inside 'provides'. Best Regards, |
|
Thanks for the PR! This is a very helpful improvement for CPAN metadata, but there is one critical typo that needs to be fixed before merging. There is a typo in 'JQ::Lite::Util::Parsing' => { file => 'lib/JQ/Lite/Uti/Parsing.pm' },
^^^It should be 'JQ::Lite::Util::Parsing' => { file => 'lib/JQ/Lite/Util/Parsing.pm' },If this is merged as-is, the CPAN META will map the module to a non-existent file, which can break indexing and tooling. Also, this PR removes Suggestion
Thanks — once the typo is fixed this PR looks good 👍 |
- Added clean key to Makefile.PL to allow dist file cleanup - Added provides to Makefile.PL
0c8809d to
8a5006d
Compare
|
@kawamurashingo Point taken well, I have updated the pull request accordingly. |
Hi @kawamurashingo
Please review the pull request.
Many Thanks.
Best Regards,
Mohammad