This repository was archived by the owner on Jun 28, 2024. It is now read-only.
Topic/fix k8s tests#462
Merged
grahamwhaley merged 2 commits intokata-containers:masterfrom Jul 2, 2018
Merged
Conversation
Contributor
chavafg
commented
Jun 29, 2018
chavafg
commented
- Remove CNI configuration before starting kubeadm
- Add kubectl describe for debugging purposes
sboeuf
reviewed
Jun 29, 2018
integration/kubernetes/init.sh
Outdated
|
|
||
| # Remove existing CNI configurations: | ||
| sudo rm -r /var/lib/cni/networks/* | ||
| sudo rm -r /etc/cni/net.d/* |
There was a problem hiding this comment.
could you move it before you start crio, just in case!
sboeuf
approved these changes
Jun 29, 2018
Member
|
after address @sboeuf comment lgtm |
chavafg
force-pushed
the
topic/fix-k8s-tests
branch
from
f6c0051 to
a20366a
Compare
Contributor
Author
|
fixed. |
Contributor
|
lgtm |
chavafg
force-pushed
the
topic/fix-k8s-tests
branch
from
a20366a to
bc36fa3
Compare
sboeuf
reviewed
Jun 29, 2018
integration/kubernetes/init.sh
Outdated
|
|
||
| # Remove existing CNI configurations: | ||
| sudo rm -r /var/lib/cni/networks/* | ||
| sudo rm -r /etc/cni/net.d/* |
There was a problem hiding this comment.
This might fail if those folders are empty, I think adding -f should help here:
sudo rm -rf /var/lib/cni/networks/*
sudo rm -rf /etc/cni/net.d/*
chavafg
force-pushed
the
topic/fix-k8s-tests
branch
2 times, most recently
from
0fedf48 to
2527737
Compare
|
@chavafg @jcvenegas we'll have to check this on Monday since it consistently fails for some new reasons now. We'll try another interactive debug session on a vexxhost machine :) |
chavafg
force-pushed
the
topic/fix-k8s-tests
branch
from
2527737 to
2fbca3e
Compare
Kubernetes will create a new cni configuration when it is initialized, and if an existing configuration is found, it can cause network errors. Fixes: kata-containers#461. Signed-off-by: Salvador Fuentes <[email protected]>
kubectl describe will allow us to know if something went wrong when launching a pod. Depends-on: github.com/kata-containers/runtime#454 Signed-off-by: Salvador Fuentes <[email protected]>
chavafg
force-pushed
the
topic/fix-k8s-tests
branch
from
2fbca3e to
4c4d363
Compare
Contributor
Author
|
@sboeuf the This was the error |
Contributor
|
Looks like @chavafg fixed the final niggle - I'm going to press the big green button.... |
Pennyzct
added a commit
to Pennyzct/tests
that referenced
this pull request
Jul 11, 2018
patch kata-containers#462(kata-containers/runtime#462) has been restructured under upstream review, so refining image-type to follow change. Fixes: kata-containers#472 Signed-off-by: Penny Zheng <[email protected]>
caoruidong
pushed a commit
to caoruidong/runtime
that referenced
this pull request
Sep 14, 2018
Some test were CI test were failing due to a race condition. Update cri-o repository to have a stable CI. Update K8s to latest stable version Depends-on: github.com/kata-containers/tests#462 Fixes: kata-containers#435 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.