Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

versions: Update cri-o to fix race condition test.#454

Merged
chavafg merged 1 commit intokata-containers:masterfrom
jcvenegas:crio-update
Jul 2, 2018
Merged

versions: Update cri-o to fix race condition test.#454
chavafg merged 1 commit intokata-containers:masterfrom
jcvenegas:crio-update

Conversation

@jcvenegas
Copy link
Member

Some test were CI test were failing due to a race condition.

Update cri-o repository to have a stable CI.

Fixes: #435

Signed-off-by: Jose Carlos Venegas Munoz [email protected]

@jcvenegas jcvenegas requested a review from sboeuf June 28, 2018 23:24
@jcvenegas jcvenegas requested a review from chavafg June 28, 2018 23:24
@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 146889 KB
Proxy: 4698 KB
Shim: 8964 KB

Memory inside container:
Total Memory: 2045968 KB
Free Memory: 2007228 KB

@sboeuf sboeuf mentioned this pull request Jun 29, 2018
@jcvenegas
Copy link
Member Author

do not merge - still see some fails - update to branch 1.11 to verify if is the branch 1.10

@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 146361 KB
Proxy: 4786 KB
Shim: 8890 KB

Memory inside container:
Total Memory: 2045968 KB
Free Memory: 2006376 KB

@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 146919 KB
Proxy: 4734 KB
Shim: 8776 KB

Memory inside container:
Total Memory: 2045968 KB
Free Memory: 2007228 KB

@sboeuf
Copy link

sboeuf commented Jun 29, 2018

@jcvenegas we need the commit e0dd8a3d4c9e5ebc8b25299950bd5b222e3783d3, was it the one you were using ?

@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 146744 KB
Proxy: 4635 KB
Shim: 8802 KB

Memory inside container:
Total Memory: 2045968 KB
Free Memory: 2007220 KB

@jodh-intel
Copy link

jodh-intel commented Jun 29, 2018

lgtm

Approved with PullApprove

@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 152074 KB
Proxy: 4652 KB
Shim: 9000 KB

Memory inside container:
Total Memory: 2045968 KB
Free Memory: 2007228 KB

@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 150382 KB
Proxy: 4692 KB
Shim: 8806 KB

Memory inside container:
Total Memory: 2045968 KB
Free Memory: 2007228 KB

Some test were CI test were failing due to a race condition.

Update cri-o repository to have a stable CI.

Update K8s to latest stable version

Depends-on: github.com/kata-containers/tests#462

Fixes: kata-containers#435

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 152179 KB
Proxy: 4650 KB
Shim: 8979 KB

Memory inside container:
Total Memory: 2045968 KB
Free Memory: 2007096 KB

@codecov
Copy link

codecov bot commented Jul 2, 2018

Codecov Report

Merging #454 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   64.13%   64.13%           
=======================================
  Files          87       87           
  Lines        8837     8837           
=======================================
  Hits         5668     5668           
  Misses       2564     2564           
  Partials      605      605

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e3997...aeea3f6. Read the comment docs.

@WeiZhang555
Copy link
Member

WeiZhang555 commented Jul 2, 2018

Is this ready for merging? @jcvenegas
LGTM

Approved with PullApprove

@chavafg
Copy link
Contributor

chavafg commented Jul 2, 2018

I think it is, but needs to be merged along kata-containers/tests#462

@chavafg
Copy link
Contributor

chavafg commented Jul 2, 2018

merging this one as kata-containers/tests#462 is already merged.

@chavafg chavafg merged commit 91cb94e into kata-containers:master Jul 2, 2018
sboeuf pushed a commit to sboeuf/tests-1 that referenced this pull request Oct 24, 2018
kubectl describe will allow us to know if something went
wrong when launching a pod.

Depends-on: github.com/kata-containers/runtime#454

Signed-off-by: Salvador Fuentes <[email protected]>
@jcvenegas jcvenegas deleted the crio-update branch January 29, 2019 18:33
@jcvenegas jcvenegas restored the crio-update branch September 30, 2019 18:47
@jcvenegas jcvenegas deleted the crio-update branch January 23, 2020 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants