This repository was archived by the owner on May 12, 2021. It is now read-only.
network: Ignore routes with proto as "kernel"#1936
Merged
egernst merged 1 commit intokata-containers:masterfrom Aug 12, 2019
Merged
network: Ignore routes with proto as "kernel"#1936egernst merged 1 commit intokata-containers:masterfrom
egernst merged 1 commit intokata-containers:masterfrom
Conversation
grahamwhaley
approved these changes
Aug 6, 2019
Contributor
grahamwhaley
left a comment
grahamwhaley
left a comment
There was a problem hiding this comment.
lgtm
nice find.
but what do I know ;-)
|
/test |
devimc
approved these changes
Aug 6, 2019
amshinde
added a commit
to amshinde/agent-1
that referenced
this pull request
Aug 6, 2019
Routes with proto kernel are automatically added by the kernel when an interface is added with ip assigned as a subnet address. With github.com/kata-containers/runtime#1936, these routes will no longer be sent from the runtime. Depends-on: github.com/kata-containers/runtime#1936 Fixes: kata-containers#623 Signed-off-by: Archana Shinde <[email protected]>
This was referenced Aug 6, 2019
Merged
amshinde
force-pushed
the
ignore-routes-with-kernel-proto
branch
from
f492701 to
b44a785
Compare
Member
Author
|
/test |
amshinde
added a commit
to amshinde/agent-1
that referenced
this pull request
Aug 6, 2019
Routes with proto kernel are automatically added by the kernel when an interface is added with ip assigned as a subnet address. With github.com/kata-containers/runtime#1936, these routes will no longer be sent from the runtime. Depends-on: github.com/kata-containers/runtime#1936 Fixes: kata-containers#623 Signed-off-by: Archana Shinde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1936 +/- ##
=========================================
Coverage ? 52.16%
=========================================
Files ? 108
Lines ? 14229
Branches ? 0
=========================================
Hits ? 7422
Misses ? 5925
Partials ? 882 |
amshinde
added a commit
to amshinde/agent-1
that referenced
this pull request
Aug 6, 2019
Routes with proto kernel are automatically added by the kernel when an interface is added with ip assigned as a subnet address. With github.com/kata-containers/runtime#1936, these routes will no longer be sent from the runtime. Depends-on: github.com/kata-containers/runtime#1936 Fixes: kata-containers#623 Signed-off-by: Archana Shinde <[email protected]>
Routes with proto "kernel" are routes that are automatically added by the kernel. It is a route added automatically when you assign an address to an interface which is not /32. With this commit, these routes are ignored. The guest kernel would add these routes on the guest side. A corresponding commit on the agent side would no longer delete these routes while updating them. Without this commit, netlink gives an error complaining that a route already exists when you try to add a route with the same dest subnet. Something like: dest: 192.168.1.0/24 device:net1 source:192.168.1.217 scope:253 dest: 192.168.1.0/24 device:net2 source:192.168.1.218 scope:253 Depends-on: github.com/kata-containers/agent#624 Fixes: kata-containers#1811 Signed-off-by: Archana Shinde <[email protected]>
amshinde
force-pushed
the
ignore-routes-with-kernel-proto
branch
from
b44a785 to
df7cf77
Compare
Member
Author
|
/test |
amshinde
added a commit
to amshinde/agent-1
that referenced
this pull request
Aug 9, 2019
Routes with proto kernel are automatically added by the kernel when an interface is added with ip assigned as a subnet address. With github.com/kata-containers/runtime#1936, these routes will no longer be sent from the runtime. Depends-on: github.com/kata-containers/runtime#1936 Fixes: kata-containers#623 Signed-off-by: Archana Shinde <[email protected]>
Member
Author
|
/test |
Member
Author
|
@chavafg @GabyCT Is this something that we have seen before. Going to rerun it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes with proto "kernel" are routes that are automatically added
by the kernel.
It is a route added automatically when you assign an address to an
interface which is not /32.
With this commit, these routes are ignored. The guest kernel
would add these routes on the guest side. A corresponding commit on the
agent side would no longer delete these routes while updating them.
Without this commit, netlink gives an error complaining that a route
already exists when you try to add a route with the same dest subnet.
Something like:
dest: 192.168.1.0/24 device:net1 source:192.168.1.217 scope:253
dest: 192.168.1.0/24 device:net2 source:192.168.1.218 scope:253
Fixes: #1811
Signed-off-by: Archana Shinde [email protected]